Dynamic registration of themes

[teunbrand]

Hi there,

We've been preparing a new major release for ggplot2 and found an issue during a reverse dependency check of shared reverse dependencies. We then traced back the issue to ComplexUpset.

In essence what happened was that ComplexUpset gets build on CRAN's machines with a fixed upset_themes list. If ggplot2 then changes an internal about how themes work, the fixed theme list does not reflect the updates. The remedy for this would be to register the upset_themes list when the ComplexUpset package is loaded (instead of when it is build). This PR dynamically sets the themes, which would resolve the issue in our shared reverse dependencies.

Please note that I wasn't able to execute the test-examples.R file, and you may have to inspect the unit tests manually. Some changes in visual tests are expected, primary due to absent axis ticks no longer taking up space.

You can test your code with the development version of ggplot2 by installing it as follows:

# install.packages("pak")
pak::pak("tidyverse/ggplot2")

We aim to release the new ggplot2 version in about 2 weeks, and hope you can submit a fix to CRAN around that time. Hopefully this will inform you in a timely manner.

Best wishes,
Teun

[teunbrand]

I see the tests fail, but to my eyes the failures are unrelated to the contents of this PR

[krassowski]

Most likely! I will try to review and merge over the upcoming weekend.

[teunbrand]

Lovely, many thanks in advance!

[teunbrand]

This is just a simple reminder.
I also believe that this PR would fix #213

[abichat]

Still get the size aesthetic for lines warning, but the error is fixed on my reprex! Thanks!