Skip to content

Fix wide paths for Windows #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wide paths for Windows #440

wants to merge 1 commit into from

Conversation

@N1kSt4r
Copy link

@N1kSt4r N1kSt4r commented Sep 4, 2023

This commit allows to open wide paths, for example, cyrilic

@N1kSt4r
Fix wide paths for Windows
29478e6 
This commit allows to open wide paths, for example, cyrilic
kpu
kpu requested changes Sep 4, 2023
View reviewed changes
Copy link
Owner

@kpu kpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but shouldn't we always convert? Otherwise I feel like there's a weird vulnerability whereby one can create a file with the unconverted name and have it take priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpu kpu kpu requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@N1kSt4r @kpu