Problem with setupAndroidProxy

[pakaufmann]

We run into problems with the setupAndroidProxy() method.

Some providers seem to set a proxy on their 3G or LET networks. Now, if this proxy is set via setupAndroidProxy(), the request can't be sent correctly and we only get a "400 Bad request". Disabling the method works.

What would be needed is a check if the wifi is connected. The problem is, you can't really check for this in setupAndroidProxy, because no context is provided anywhere.

private boolean isWifiConnected()
{
    Object o = null;
    if (context != null && context.getApplicationContext() != null) {
        o = context.getApplicationContext().getSystemService(Context.CONNECTIVITY_SERVICE);
    }
    NetworkInfo wifi = null;
    if (o != null && o instanceof ConnectivityManager) {
        ConnectivityManager connManager = (ConnectivityManager)o;
        wifi = connManager.getNetworkInfo(ConnectivityManager.TYPE_WIFI);
    }
    return wifi != null && wifi.isConnected();
}

[koush]

It's trying to use the mobile network proxy against the Wifi network?

[pakaufmann]

Exactly.

[pakaufmann]

Just for clarification. I would like to submit a fix, but at the moment I don't see how it's possible without altering a large part of the library. The problem is, in order to check for the wifi a Context is needed, but it's not really possible to get an android context at the point where one would be needed. I also cannot remove the method just in my code, because the class the setupAndroidProxy() method is on is instatiated as a singleton somewhere, so it's not possible to just subclass it.

Would it be possible to have some sort of config in order to disable the feature, or even better, enable it optionally? If yes, is there some sort of config class which I could use to create such a feature?

[koush]

I'm wondering how HttpUrlConnection does it, as it does not require a context.

[koush]

The other issue is that wifi could still use have a proxy, so this may not be correct.

I think if the proxy is implicitly enabled, I can fall back to not using a proxy.

[pakaufmann]

The Wifi issue is true, that's why we check if the wifi is connected and only set the proxy if that's true. It would be nice to somehow opt-out of the automatic proxy detection if we want to set our own proxy, or disable it completely.

[juanmougan]

I've submitted a pull request using @Kufi 's workaround