Skip to content

Revisit includes and excludes logic #22

@tisonkun

Description

@tisonkun

Currently, we build includes and excludes in Selection using buildOverrideInclusions, buildExclusions and buildInclusions.

I don't think it's a clean way and I don't agree that we should explicitly specify exact includes to remove default exclusions.

Basically, we should evaluate includes and excludes with priority and acting like a painter:

  1. Filter if in default includes if no user-defned includes.
  2. If in default excludes, pending to be ignored.
  3. If in user-defined includes, bring it back.
  4. If in user-defined excludes, kick it off again.

In this way, we can append and plugin includes and excludes like the idea in #20 to respect .gitignore configs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions