✨ Ensure addon adapter logs stack traces.

[jortel]

The adapter used to log errors but got removed in some previous patch.

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling and logging for addon failures, ensuring errors are now explicitly logged when they occur.
  • Enhanced error messages in task data processing for better clarity and troubleshooting.

[coderabbitai]

Walkthrough

The changes introduce improved error handling and logging in the addon package. A new error wrapping utility is integrated, used within the Task.DataWith method and made globally available via a variable. Additionally, an explicit error log statement is added to the Adapter.Run method's error handling block.

Changes

Cohort / File(s)	Change Summary
Error Wrapping Integration addon/adapter.go	Added import for liberr error wrapping, introduced global Wrap variable, and enhanced error logging in Adapter.Run by logging errors explicitly before exiting.
Error Wrapping in Task Data Handling addon/task.go	Updated Task.DataWith to wrap errors from json.Unmarshal using the new Wrap function, improving error context.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Adapter
    participant Handler
    participant Logger

    User->>Adapter: Run()
    Adapter->>Handler: (defer) On error, call Failed(err.Error())
    Adapter->>Logger: (defer) On error, log Error(err, "Addon failed.")
    Adapter-->>User: Exit with error (if any)

Loading

sequenceDiagram
    participant Task
    participant JSON
    participant ErrorWrapper

    Task->>JSON: Unmarshal(data, obj)
    JSON-->>Task: error (if any)
    Task->>ErrorWrapper: Wrap(error)
    ErrorWrapper-->>Task: wrapped error
    Task-->>Caller: Return wrapped error

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A bunny hops through lines of code,
Wrapping errors as they go,
Logging troubles with a friendly glow.
Now when things go wrong,
The logs will sing a clearer song—
With every hop, the code grows strong!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea399b9 and 7c170dc.

📒 Files selected for processing (2)

• addon/adapter.go (3 hunks)
• addon/task.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: test-unit
• GitHub Check: build
• GitHub Check: vet

🔇 Additional comments (4)

addon/adapter.go (3)

11-11: LGTM! Clean import addition.

The import of the error wrapping library with appropriate aliasing enables the enhanced error handling functionality introduced in this PR.

---

21-21: LGTM! Well-designed global alias.

The Wrap variable provides a convenient package-level alias for error wrapping, following the same pattern as other global variables in this section.

---

133-133: Excellent error logging enhancement!

The addition of explicit error logging provides valuable debugging information when addon execution fails. This complements the existing error reporting and aligns perfectly with the PR objective of improving error visibility.

addon/task.go (1)

121-121: Ensure Wrap handles nil errors

Wrap is aliased to liberr.Wrap in addon/adapter.go. Please confirm that when passed a nil error, liberr.Wrap(nil) returns nil (i.e., it handles nil inputs gracefully) to prevent any unintended panics.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.