Skip to content

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Jul 28, 2025

Add generator.description.

fixes #852

Summary by CodeRabbit

  • New Features
    • Added support for an optional "Description" field to generators, allowing users to include descriptive text.
  • Tests
    • Updated sample data to include the new "Description" field for improved test coverage.

Copy link

coderabbitai bot commented Jul 28, 2025

Walkthrough

A new Description field was added to the Generator struct across the API, model, and test layers. Serialization tags and conversion logic were updated to support this field, ensuring it is handled during transformations between API resources and internal models. Test samples were also updated to include the new field.

Changes

Cohort / File(s) Change Summary
API Struct & Conversion Logic
api/generator.go
Added Description field to Generator struct; updated With and Model methods to handle the new field.
Model Struct
migration/v18/model/platform.go
Added Description field to Generator struct in model definition.
Test Sample Update
test/api/generator/samples.go
Added Description field with sample value to test Base variable.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API
    participant Model

    Client->>API: POST/PUT /generators (with Description)
    API->>API: Unmarshal JSON (includes Description)
    API->>Model: Convert to model (pass Description)
    Model-->>API: Return model (with Description)
    API-->>Client: Respond with resource (includes Description)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective Addressed Explanation
Add description field to Generator entity and ensure it is available for create/update APIs (#852)

Poem

A new field hops in, called Description—
Now Generators have more definition!
Models and APIs in sync,
Tests updated in a blink.
The codebase grows with gentle precision,
Thanks to this fluffy revision!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b11d203 and e28b849.

📒 Files selected for processing (3)
  • api/generator.go (2 hunks)
  • migration/v18/model/platform.go (1 hunks)
  • test/api/generator/samples.go (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
test/api/generator/samples.go (1)

Learnt from: jortel
PR: #849
File: test/api/application/manifest_test.go:33-33
Timestamp: 2025-07-09T11:55:52.155Z
Learning: The test TestAppManifestGet in test/api/application/manifest_test.go is intentionally designed to test the application-scoped manifest API functionality. It deliberately uses Application.Manifest(application.ID) for operations that are supported (Create, Get) while using RichClient.Manifest.Delete for cleanup operations that are not supported by the application-scoped API.

🧬 Code Graph Analysis (1)
api/generator.go (4)
api/base.go (3)
  • Resource (290-295)
  • Map (352-352)
  • Ref (340-343)
api/application.go (1)
  • Repository (1494-1500)
test/assert/equality.go (1)
  • Map (9-9)
migration/v18/model/platform.go (1)
  • Generator (33-44)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: test-unit
  • GitHub Check: build
  • GitHub Check: vet
🔇 Additional comments (5)
migration/v18/model/platform.go (1)

33-44: LGTM! Description field correctly added to the model.

The Description field is properly added as a string type to the Generator struct, maintaining consistency with the naming conventions and field positioning. This change aligns with the PR objective to support the description field in generator create/update operations.

test/api/generator/samples.go (1)

9-24: LGTM! Test sample properly includes the new Description field.

The Description field is correctly added to the test sample with an appropriate test value. This ensures the new field is covered in test scenarios and maintains consistency with the API structure changes.

api/generator.go (3)

168-178: LGTM! Description field properly added to API struct with correct serialization tags.

The Description field is correctly added with appropriate JSON and YAML tags including omitempty for optional serialization. The field positioning and type are consistent with the model layer.


181-197: LGTM! With method correctly populates Description field from model.

The Description field assignment is properly added to the conversion method, ensuring the description is correctly transferred from the model to the API resource during serialization.


199-215: LGTM! Model method correctly sets Description field from API resource.

The Description field assignment is properly added to the conversion method, ensuring the description is correctly transferred from the API resource to the model during create/update operations. This directly addresses the issue where POST/PUT requests with description field would fail.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel jortel requested a review from aufi July 28, 2025 20:34
@jortel jortel merged commit ea399b9 into konveyor:main Jul 28, 2025
16 checks passed
@jortel jortel removed the request for review from aufi July 28, 2025 20:49
sjd78 added a commit to sjd78/tackle2-ui that referenced this pull request Jul 28, 2025
Follow-up: konveyor#2482, konveyor#2499
Ref: konveyor/tackle2-hub#860

Enable saving the description field when Creating/Updating Generators

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit to konveyor/tackle2-ui that referenced this pull request Jul 28, 2025
Follow-up: #2482, #2499
Ref: konveyor/tackle2-hub#860

Enable saving the description field when Creating/Updating Generators

Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Generator entity is misssing a description field
3 participants