-
Notifications
You must be signed in to change notification settings - Fork 35
🐛 Add generator.description. #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jeff Ortel <[email protected]>
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API
participant Model
Client->>API: POST/PUT /generators (with Description)
API->>API: Unmarshal JSON (includes Description)
API->>Model: Convert to model (pass Description)
Model-->>API: Return model (with Description)
API-->>Client: Respond with resource (includes Description)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Assessment against linked issues
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (1)test/api/generator/samples.go (1)Learnt from: jortel 🧬 Code Graph Analysis (1)api/generator.go (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow-up: konveyor#2482, konveyor#2499 Ref: konveyor/tackle2-hub#860 Enable saving the description field when Creating/Updating Generators Signed-off-by: Scott J Dickerson <[email protected]>
Follow-up: #2482, #2499 Ref: konveyor/tackle2-hub#860 Enable saving the description field when Creating/Updating Generators Signed-off-by: Scott J Dickerson <[email protected]>
Add generator.description.
fixes #852
Summary by CodeRabbit