-
Notifications
You must be signed in to change notification settings - Fork 41
✨ Add kai solution server to release pipeline #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Fabian von Feilitzsch <[email protected]>
WalkthroughThe Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/create-release.yml
(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-operator-bundle
🔇 Additional comments (3)
.github/workflows/create-release.yml (3)
127-142
:kai
release added in release-bases ‑ looks correct by itself
The step follows the established pattern for other base images (create-release + wait-for-image) – nice and consistent.
239-239
: Verify the composite action supports the newkai
input
./operator/.github/actions/make-bundle
previously accepted a fixed set of image arguments. If that action’sinputs:
block hasn’t been updated to includekai
, the job will fail with
Unexpected input(s) 'kai'
.Please double-check the composite action, or update it accordingly.
356-357
: Changelog aggregation extended – LGTM
Includingkonveyor/kai
here keeps the release notes complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably also need to look at updating our config in release tools to get kai and editor-extensions repo in line with the rest of konveyor.
https://github.com/konveyor/release-tools/tree/main/pkg/config
Signed-off-by: Fabian von Feilitzsch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Closes #448
Summary by CodeRabbit