Break build on SASS compilation errors

[peterwurzinger]

Is your feature request related to a problem? Please describe.
I guess it's not really a problem, rather than a QOL thing.

Describe the solution you'd like
If the SASS compilation fails, the MSBuild Task should also fail. E.g. I edited my main.scss to import a file that doesn't exist, I can see the output

AspNetCore.SassCompiler.targets(16,5): error : Error: Can't find stylesheet to import.
AspNetCore.SassCompiler.targets(16,5): error :   ╷
AspNetCore.SassCompiler.targets(16,5): error : 8 │ @import "whatever";
AspNetCore.SassCompiler.targets(16,5): error :   │         ^^^^^^^^^^

and the main.css then contains the error as -content.

It would be great being able to express something like

<PropertyGroup>
  <!-- Emit a build error if the SASS compiler is sad -->
  <SassCompilerErrorSeverity>Error</SassErrorSeverity>

  <!-- Or go even further -->
  <SassCompilerTreatWarningsAsErrors>true<SassTreatWarningsAsErrors>
</PropertyGroup>

Describe alternatives you've considered
Couldn't really think of any.

Additional context
Thanks for your work guys! :)

[adiessl]

We also had this problem and solved it by setting the Arguments (see https://github.com/koenvzeijl/AspNetCore.SassCompiler?tab=readme-ov-file#available-options) appropriately, i.e. using --no-error-css --stop-on-error.

[peterwurzinger]

@adiessl Oh, thanks, that's a neat way of achieving exactly that - thanks!

I mean, I'll keep the issue open just for documentation purpose and to get a glimpse on what maintainers think about that feature in general. E.g. with too much free time one could potentially parse the Dart-Sass output and emit MSBuild Errors and Warnings for each output artifact, even point to files and lines,...