-
Notifications
You must be signed in to change notification settings - Fork 38
circuit breaker increase volume and only log connection failures #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found critical issues please review the requested changes
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request focuses on improving the error handling and circuit breaker logic within the
kodus-ai
repository. Specifically, it introduces changes in two files:src/ee/kodyAST/codeASTAnalysis.service.ts
: The update enhances the task polling mechanism by implementing specific error handling forNOT_FOUND
status. This change allows the system to recognize a terminal error state and stop the retry loop, preventing unnecessary polling for non-existent tasks and enabling faster failure responses.src/shared/utils/rxjs/circuit-breaker.ts
: The circuit breaker logic is refined to only log specific gRPC connection errors as failures, while increasing thevolumeThreshold
from 10 to 50. This adjustment aims to reduce the sensitivity of the circuit breaker to low traffic volumes. However, the current implementation may inadvertently treat non-connection errors as successes, suggesting a need for further flexibility.Overall, these changes aim to enhance system reliability by improving error handling and adjusting the circuit breaker's sensitivity to traffic volumes.