Having error with whatsapp

[dgillier]

Hello,

I'm trying to use goodshare.js with whatsapp.

I'm using :


WhatsApp

And I'm getting an error on whatsapp
(url : https://api.whatsapp.com/resolve?deeplink=/%3Ftext%3Dhttps%253A%252F%252Fxxxxxxx.ngrok.io%252Fcourses%252Fclass-cyrill-11-06-2020)

Any idea what I'm doing wrong ?
Thanks, Denis

[welcome]

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template!

[koddr]

@dgillier Hi!

Can you please share your code example?

[dgillier]

oh sorry...
Here it is:

                     <button type="button" data-social="whatsapp" data-title="{{$course->title}}" data-description="Test" data-image="{{ URL::asset('img/brand/bms-favicon.png') }}" class="mt-2 btn btn-slack btn-icon-label" style="min-width:12rem;">
                                        <span class="btn-inner--icon"><i class="fab fa-whatsapp"></i></span>
                                        <span class="btn-inner--text">WhatsApp</span>
                                    </button>

[koddr]

Thx!

I see, you missed data-url. Try to add this attribute.

[dgillier]

Thanks, I was lazy (though if no data-url, plugin will get document url ;) Unfortunately got the same error with: <button type="button" data-social="whatsapp" data-title="Test" data-url="https://xxxxxx.ngrok.io/courses/test-01-06-2020" data-description="test" data-image="https://xxxxxx.ngrok.io/img/brand/bms-favicon.png" class="mt-2 btn btn-slack btn-icon-label" style="min-width:12rem;"> <span class="btn-inner--icon"><i class="fab fa-whatsapp"></i></span> <span class="btn-inner--text">WhatsApp</span> </button>

…

On 11 Jun 2020, at 16:49, Vic Shóstak ***@***.***> wrote: Thx! I see, you missed data-url. Try to add this attribute. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[koddr]

Unfortunetly got the same error with: [...]

Hmm... 🤔 Can you please share screenshot with errors in your browser's console?

[dgillier]

looked at your code : getPreparedData(item) { const url = item.dataset.url ? encodeURIComponent(item.dataset.url) : this.url; const share_url = `https://wa.me/?text=${url}`; return { callback: this.callback, share_url: share_url, windowTitle: "Share this", windowWidth: 640, windowHeight: 480 }; } Looks like anything sent to https://wa.me/ is returning the same error, so maybe they changed the API ?

…

On 11 Jun 2020, at 17:30, Vic Shóstak ***@***.***> wrote: Unfortunately got the same error with: [...] Hmm... 🤔 Can you please share screenshot with errors in your browser's console? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[koddr]

Yep, API was changed.

I fix it today.

[dgillier]

Thanks !

[koddr]

Fix at v6.1.5

Thanks for reply! 👍