-
-
Notifications
You must be signed in to change notification settings - Fork 366
refactor: oruga composition api #8972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Code Climate has analyzed commit 91114cb and detected 0 issues on this pull request. View more on Code Climate. |
|
AI-Generated Summary: This pull request primarily consists of refactoring done across various Vue and SCSS files. The bulk of the changes involve a transition from the Oruga UI library version In terms of Vue components, there is a significant rework seen in There are also changes spotted in Additionally, updates are seen in The only configuration change noticed was in As SCSS files pathway changes are fairly common throughout, keep an eye out for any possible style deviations, observing closely the impact of additional new imports, Barring few exceptions, the overall structure and logic of the code haven't been evidently altered. However, thorough testing and a detailed review would still be paramount due to the substantial number of files affected. |
Reviewpad Report
|
no advantages in continuing to develop on this branch? is it the new composition api that causing all issue? |
I couldn't make it. This is my 1st attempt to upgrade the Oruga package. On 2nd attempt locally, I tried to use multiple versions of Oruga and wanted to check it one by one. But the result is the same: the component does not render. I think the problem is we can't use I think the possible way is we need to |
It seems like the options for us are:
|
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context