WIP: Vue to Nuxt migration #843

dezine2dev · 2021-10-05T11:09:28Z

Story
Migration nft-gallery into Nuxt

Summary
This is work in progress
Everything is in /nuxt folder. (One everything is done, it will be replaced with root folder)
node version - v16

Related #584
Related #912

https://koda-nuxt.netlify.app/ for main-nuxt branch

feat(profile): add pagination & current tab on url

fix(toggleLayout): default value incorect

Added postfix to the classic mint

…orator

yangwao · 2021-11-03T13:58:43Z

When I clicked to from https://deploy-preview-843--koda-nuxt.netlify.app/rmrk/gallery/9935513-466e8b6338599eaf1e-GAVCUBE-GAV_CUBE_056-0000000000000056

to profile author

I landed on a blank screen, the probably routing is broken?

dezine2dev · 2021-11-03T14:08:16Z

When I clicked to from https://deploy-preview-843--koda-nuxt.netlify.app/rmrk/gallery/9935513-466e8b6338599eaf1e-GAVCUBE-GAV_CUBE_056-0000000000000056

to profile author

I landed on a blank screen, the probably routing is broken?

Yes it is another routing breaks.
I will handle that and possible other things as well.
The main reason of this kind of issues is because original app handles routing by name and that name does not match in nuxt. Nuxt creates routing name by folder structure and I need to do navigation by path.

hound · 2021-11-05T03:30:36Z

nuxt/.eslintrc.js

+      'plugin:vue/recommended',
+      // 'prettier',
+    ],
+}


Missing semicolon.

hound · 2021-11-05T03:30:37Z

nuxt/.eslintrc.js

+      'plugin:vue/recommended',
+      // 'prettier',
+    ],
+}


Missing semicolon.

hound · 2021-11-05T03:30:38Z

nuxt/nuxt.config.js

+      }
+    }
+  },
+}


Missing semicolon.

hound · 2021-11-05T03:30:38Z

nuxt/nuxt.config.js

+    extend (config, { isDev, isClient }) {
+      config.node = {
+        fs: 'empty'
+      }


Missing semicolon.

hound · 2021-11-05T03:30:38Z

nuxt/nuxt.config.js

+
+  // Build Configuration: https://go.nuxtjs.dev/config-build
+  build: {
+    extend (config, { isDev, isClient }) {


'concise methods' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2021-11-05T03:30:38Z

nuxt/nuxt.config.js

@@ -0,0 +1,137 @@
+export default {


'export' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:30:39Z

nuxt/params/components/findComponent.js

+            return type;
+    }
+});
+export default function findComponent(def, overrides = {}) {


'default parameters' is only available in ES6 (use 'esversion: 6').
'export' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:30:39Z

nuxt/params/components/findComponent.js

+            return 'Tuple';
+        case TypeDefInfo.Vec:
+            return ['Vec<KeyValue>'].includes(type)
+                ? 'Vec<KeyValue>'


Misleading line break before '?'; readers may interpret this as an expression boundary.

hound · 2021-11-05T03:30:39Z

nuxt/params/components/findComponent.js

+    });
+    return componentList;
+}, {});
+const getType = (({ displayName, info, sub, type }) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2021-11-05T03:30:40Z

nuxt/params/components/findComponent.js

+    { c: VoteThreshold, t: ['VoteThreshold'] },
+    { c: Unknown, t: ['Unknown'] },
+].reduce((componentList, { c, t }) => {
+    t.forEach((type) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:30:40Z

nuxt/params/components/findComponent.js

+    { c: Vote, t: ['Vote'] },
+    { c: VoteThreshold, t: ['VoteThreshold'] },
+    { c: Unknown, t: ['Unknown'] },
+].reduce((componentList, { c, t }) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2021-11-05T03:30:41Z

nuxt/nuxt.config.js

+      }
+    }
+  },
+}


Missing semicolon.

hound · 2021-11-05T03:30:41Z

nuxt/nuxt.config.js

+    extend (config, { isDev, isClient }) {
+      config.node = {
+        fs: 'empty'
+      }


Missing semicolon.

hound · 2021-11-05T03:30:41Z

nuxt/nuxt.config.js

+
+  // Build Configuration: https://go.nuxtjs.dev/config-build
+  build: {
+    extend (config, { isDev, isClient }) {


'concise methods' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2021-11-05T03:30:41Z

nuxt/nuxt.config.js

@@ -0,0 +1,137 @@
+export default {


'export' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:30:42Z

nuxt/params/components/findComponent.js

+        catch (error) {
+            // console.error(error.message);
+        }
+        console.warn(`Cannot find Component for ${type}, defaulting to Unknown`);


'template literal syntax' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:30:43Z

nuxt/params/components/findComponent.js

+            return 'Tuple';
+        case TypeDefInfo.Vec:
+            return ['Vec<KeyValue>'].includes(type)
+                ? 'Vec<KeyValue>'


Misleading line break before '?'; readers may interpret this as an expression boundary.

hound · 2021-11-05T03:30:43Z

nuxt/params/components/findComponent.js

+    });
+    return componentList;
+}, {});
+const getType = (({ displayName, info, sub, type }) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2021-11-05T03:30:43Z

nuxt/params/components/findComponent.js

+    { c: VoteThreshold, t: ['VoteThreshold'] },
+    { c: Unknown, t: ['Unknown'] },
+].reduce((componentList, { c, t }) => {
+    t.forEach((type) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:30:43Z

nuxt/params/components/findComponent.js

+    { c: Vote, t: ['Vote'] },
+    { c: VoteThreshold, t: ['VoteThreshold'] },
+    { c: Unknown, t: ['Unknown'] },
+].reduce((componentList, { c, t }) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2021-11-05T03:30:43Z

nuxt/params/components/findComponent.js

+import Vector from './Vector.vue';
+import Vote from './Vote.vue';
+import VoteThreshold from './VoteThreshold.vue';
+const components = [


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2021-11-05T03:31:33Z

nuxt/params/components/findComponent.js

+import Unknown from './Unknown.vue';
+import Vector from './Vector.vue';
+import Vote from './Vote.vue';
+import VoteThreshold from './VoteThreshold.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:31:34Z

nuxt/params/components/findComponent.js

+import Tuple from './Tuple.vue';
+import Unknown from './Unknown.vue';
+import Vector from './Vector.vue';
+import Vote from './Vote.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:31:34Z

nuxt/params/components/findComponent.js

+import TextField from './TextField.vue';
+import Tuple from './Tuple.vue';
+import Unknown from './Unknown.vue';
+import Vector from './Vector.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:31:34Z

nuxt/params/components/findComponent.js

+import Struct from './Struct.vue';
+import TextField from './TextField.vue';
+import Tuple from './Tuple.vue';
+import Unknown from './Unknown.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:31:34Z

nuxt/params/components/findComponent.js

+import Raw from './Raw.vue';
+import Struct from './Struct.vue';
+import TextField from './TextField.vue';
+import Tuple from './Tuple.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:31:35Z

nuxt/params/components/findComponent.js

+import Hash512 from './Hash512.vue';
+import KeyValue from './KeyValue.vue';
+import KeyValueArray from './KeyValueArray.vue';
+import Moment from './Moment.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:31:35Z

nuxt/params/components/findComponent.js

+import Hash256 from './Hash256.vue';
+import Hash512 from './Hash512.vue';
+import KeyValue from './KeyValue.vue';
+import KeyValueArray from './KeyValueArray.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:31:35Z

nuxt/params/components/findComponent.js

+import Enum from './Enum.vue';
+import Hash256 from './Hash256.vue';
+import Hash512 from './Hash512.vue';
+import KeyValue from './KeyValue.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:31:36Z

nuxt/params/components/findComponent.js

+import DispatchError from './DispatchError.vue';
+import Enum from './Enum.vue';
+import Hash256 from './Hash256.vue';
+import Hash512 from './Hash512.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T03:31:36Z

nuxt/params/components/findComponent.js

+import Code from './Code.vue';
+import DispatchError from './DispatchError.vue';
+import Enum from './Enum.vue';
+import Hash256 from './Hash256.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T11:44:03Z

src-functions/unpin.js



  } catch (e) {
    console.log('Error', e.message)
    return {
      statusCode: 500,
      body: e.message,
-    };
+    }


Missing semicolon.

hound · 2021-11-05T11:44:03Z

src-functions/unpin.js


    return {
      statusCode: status,
      body: JSON.stringify(data),
-    };
+    }


Missing semicolon.

hound · 2021-11-05T11:44:03Z

src-functions/unpin.js

-    });
-    console.log('[PINATA] Pin HASH', status, data);
+    })
+    console.log('[PINATA] Pin HASH', status, data)


Missing semicolon.

hound · 2021-11-05T11:44:03Z

src-functions/unpin.js

@@ -21,22 +21,22 @@ exports.handler = async (event, context) => {
        pinata_api_key: process.env.PINATA_API_KEY,
        pinata_secret_api_key: process.env.PINATA_SECRET_API_KEY
      },
-    });
-    console.log('[PINATA] Pin HASH', status, data);
+    })


Missing semicolon.

hound · 2021-11-05T11:44:04Z

src-functions/unpin.js

  }

-  const BASE_URL = `https://api.pinata.cloud/pinning/unpin/${hash}`;
+  const BASE_URL = `https://api.pinata.cloud/pinning/unpin/${hash}`


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'template literal syntax' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

hound · 2021-11-05T11:44:05Z

vue.config.js

+      scssRule.uses.clear()
+      scssRule
+        .use('null-loader')
+        .loader('null-loader')


Missing semicolon.

hound · 2021-11-05T11:44:05Z

vue.config.js

@@ -28,13 +28,20 @@ module.exports = {
  },

  chainWebpack: config => {
+    if (process.env.NODE_ENV === 'test') {
+      const scssRule = config.module.rule('scss')
+      scssRule.uses.clear()


Missing semicolon.

hound · 2021-11-05T11:44:05Z

vue.config.js

@@ -28,13 +28,20 @@ module.exports = {
  },

  chainWebpack: config => {
+    if (process.env.NODE_ENV === 'test') {
+      const scssRule = config.module.rule('scss')


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

hound · 2021-11-05T11:44:05Z

nuxt/params/components/findComponent.js

+import Call from './Call.vue';
+import Code from './Code.vue';
+import DispatchError from './DispatchError.vue';
+import Enum from './Enum.vue';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2021-11-05T11:44:05Z

nuxt/params/components/findComponent.js

+import Bytes from './Bytes.vue';
+import Call from './Call.vue';
+import Code from './Code.vue';
+import DispatchError from './DispatchError.vue';


'import' is only available in ES6 (use 'esversion: 6').

roiLeo and others added 30 commits October 1, 2021 09:41

feat(profile): remove unused property

40d1025

Merge pull request #828 from roiLeo/feature/profile/paging

610bde3

feat(profile): add pagination & current tab on url

Merge branch 'main' into feature/component/rankings

2493e45

feat(rankings): paging option on rows change

0791596

Merge remote-tracking branch 'upstream/main' into feat-orientation

20b1d18

fix for fullscreen break

d2ccf2e

fix(collection): unify label style with gallery

1e2daa3

fixed 1 by 1

7174a03

Nuxt-migration: create initial nuxt project

296638c

Nuxt-migration: Simply copy styles

19f9752

Nuxt-migration: Add langDir and Queries

b99d8f5

Nuxt-migration: Add Footer and Navbar components

6129331

Nuxt-migration: Nuxt and eslint config

98a43bd

Nuxt-migration: Store basic configuration

2633c62

Nuxt-migration: Copy few necessity files for util

ee98019

Nuxt-migration: Copy and update utils

51bdc26

Nuxt-migration: Install polkadot files

8794af1

App should correctly show fullscreen

62e55bb

813 reflexed fullscreen

401d992

Flexed theatre mode

de4cd6d

813 css scoped

0b19063

fix(pricechart): hideoverlapping label on x axis

b1fa5e6

fix(pricechart): linting

f04d3ee

check mate we don't have token

f274b52

note for me eeh don use web again

7459ca2

note for me eeh don use web again

b6c9aca

49 sort is back

28b3692

chore(clean): remove unused property

8d4d1ed

chore(clean): return type on routeGuard

83e14c0

chore(clean): type on routeGuard

99b281b

yangwao and others added 11 commits November 2, 2021 13:45

Merge pull request #1003 from roiLeo/hotfix/toggleLayout

c401a23

fix(toggleLayout): default value incorect

Merge pull request #998 from kodadot/expert-mint-is-cool

b4176ab

Added postfix to the classic mint

fixed grammarly

734914a

Merge branch 'main' of github.com:kodadot/nft-gallery into issue/584

7b573df

Nuxt-migration: Auto import for components folder

eb9afe8

Nuxt-migration: Fix routing for the navbar

0d2e336

Nuxt-migration: Fix broken routings

947aec5

Nuxt-migration: Update changed queries folder

66c194e

Nuxt-migration: Update missing components

e012bba

Nuxt-migration: Add admin page

c6fb013

Nuxt-migration: Replace vue-property-decorator with nuxt-property-dec…

d15ccf9

…orator

yangwao mentioned this pull request Nov 4, 2021

Fill up return types #1028

Closed

Isa Noguchi added 6 commits November 5, 2021 10:22

Nuxt-migration: Update langDir

7460fbc

Nuxt-migration: 404 redirect and Error page

4efbafb

Nuxt-migration: Remove unused components

1e3859e

Nuxt-migration: Fix broken routes

a148182

Nuxt-migration: Update configs

fba0a20

Nuxt-migration: Add identity page

3b65c5d

hound bot reviewed Nov 5, 2021

View reviewed changes

nuxt/.eslintrc.js

'plugin:vue/recommended',

// 'prettier',

],

}

Copy link

hound bot Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

hound bot reviewed Nov 5, 2021

View reviewed changes

Nuxt-migration: Add Discord card in landing page

3e20f90

hound bot reviewed Nov 5, 2021

View reviewed changes

This was referenced Nov 8, 2021

dead lift issue #1059

Closed

KodaDot 2.0 - beta & migration #1060

Closed

yangwao merged commit b89f5df into main-nuxt Nov 9, 2021

yangwao deleted the issue/584 branch January 13, 2022 13:36

Uh oh!

WIP: Vue to Nuxt migration #843

WIP: Vue to Nuxt migration #843

Uh oh!

Conversation

dezine2dev commented Oct 5, 2021 • edited by yangwao Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yangwao commented Nov 3, 2021

Uh oh!

dezine2dev commented Nov 3, 2021

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

hound bot Nov 5, 2021

Choose a reason for hiding this comment

dezine2dev commented Oct 5, 2021 •

edited by yangwao

Loading