Skip to content

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Sep 24, 2021

Thank you for your contribution to the KodaDot NFT gallery,
we really appreciate your contribution!

Reducing bundle size and adding features :)) #439

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting this PR, please make sure:

  • Your code builds clean without any erros or warnigns
  • You've posted screenshot of demonstrated change in this PR
  • Merged recent default branch, main and you have no conflicts
  • Didn't break any original functionality

BEFORE
Screenshot 2021-09-24 at 23 34 20

AFTER
Screenshot 2021-09-24 at 23 34 06

@vikiival vikiival requested review from roiLeo and yangwao September 24, 2021 21:35
@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

You're Pull Request scored a 0.04938271604938271 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@yangwao
Copy link
Member

yangwao commented Sep 25, 2021

Yeah we had it once back in, you need fix conflict 👀

@yangwao
Copy link
Member

yangwao commented Sep 25, 2021

I've did 🤙

@github-actions
Copy link
Contributor

Gif

@yangwao yangwao merged commit a771d72 into main Sep 25, 2021
@vikiival vikiival deleted the just-markdown branch September 25, 2021 12:21
@vikiival
Copy link
Member Author

Perfect, thanks @yangwao for resolving the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants