Skip to content

Conversation

chris-sab
Copy link

Show emojis on Item or hide it on list.

@chris-sab chris-sab changed the title show see emoji on gallery item Show see emoji on gallery item Aug 12, 2021
@chris-sab
Copy link
Author

@roiLeo please check this PR.

@chris-sab
Copy link
Author

This is the result:
image

@yangwao
Copy link
Member

yangwao commented Aug 17, 2021

Oh this is awesome @chris-saburo !

@yangwao yangwao merged commit 14e489f into kodadot:main Aug 17, 2021
@vikiival
Copy link
Member

@yangwao: This is not the fix I guess

The problem is that when you are logged in you can see the emotes.
Screenshot 2021-08-17 at 11 08 35

However, when you are logged out you cannot see the emote button and the emotes.

Fix:
In GalleryItem I misplaced the v-if on Appreciation. The fix is to put the v-if into the Appreciation and only show emoteButton only if you are logged in

@chris-sab chris-sab deleted the 597-see-emoji-gallery branch August 17, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants