Skip to content

#1769 FIX Warning on navigationDuplicated in Transfer #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

atharva3010
Copy link
Contributor

@atharva3010 atharva3010 commented Jan 11, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes Warning on navigationDuplicated in Transfer #1769
  • Fixes the warnings for duplicate navigation, as pointed in the issue.
  • Refactors the watchers to reduce bloat and make code easy to read.
  • Removes PostCSS that wasn't being used, to rid of the below warnings:
    image

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main-nuxt and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 24ce6f6

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61ddedf70cf4800008417df7

😎 Browse the preview: https://deploy-preview-1773--koda-nuxt.netlify.app

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think we have other route/component where Navigation Duplicate throw warning:

  • Pagination
  • SearchBar
  • SearchBarCollection
  • SeriesTable

@atharva3010
Copy link
Contributor Author

@roiLeo if you can point out to the routes themselves that throw the warning, I can fix them too. I don't have the full context to reproduce the navigation errors in those components.

@yangwao
Copy link
Member

yangwao commented Jan 12, 2022

I've added postcss explicitly to mitigate vulnerability 6eae704

GHSA-566m-qj78-rww5

By removing you are introducing it back until the dependant package has updated it.
Have you checked this?

@atharva3010
Copy link
Contributor Author

@yangwao how will the dependent package access KodaDot's PostCSS version?
It does not work like that, if you inspect the yarn.lock file and do a search for postcss you can find a number of packages using their own specified versions of postcss.
Only when they update their versions, the vulnerability gets fixed and you'll start to see the versions in their dependencies reflect that.

Adding postcss to KodaDot when it is not being utilised by the project itself is just wasted resources.

@yangwao
Copy link
Member

yangwao commented Jan 13, 2022

@yangwao yangwao merged commit 672b25e into kodadot:main-nuxt Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on navigationDuplicated in Transfer
3 participants