Skip to content

Load collection detail chart data when activity tab is clicked #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Load collection detail chart data when activity tab is clicked #1762

merged 1 commit into from
Jan 11, 2022

Conversation

chandradot99
Copy link
Contributor

@chandradot99 chandradot99 commented Jan 11, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main-nuxt and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: b819901

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61dd12eee1c1390008a308fb

😎 Browse the preview: https://deploy-preview-1762--koda-nuxt.netlify.app

@chandradot99 chandradot99 changed the title Load activity chart data when tab is clicked Load Collection detail chart data when activity tab is clicked Jan 11, 2022
@chandradot99 chandradot99 changed the title Load Collection detail chart data when activity tab is clicked Load collection detail chart data when activity tab is clicked Jan 11, 2022
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested on /rmrk/collection/800f8a914281765a7d-KITTY 🆗
  • Let's say a new element is added to collection, would it be possible to refresh graph on demand?

@chandradot99
Copy link
Contributor Author

@roiLeo yes it's possible, for that we have to add refresh button somewhere on top of chart. Should I add that refresh functionality also in this PR.

@roiLeo
Copy link
Contributor

roiLeo commented Jan 11, 2022

we can leave it like that for the moment, the refresh functionality will not be in this same component

@yangwao
Copy link
Member

yangwao commented Jan 11, 2022

we can leave it like that for the moment, the refresh functionality will not be in this same component

I guess subsquid/subquery has some listener for events? cc @vikiival

Check how it's made for example once you are on NFT item detail and meanwhile someone made a action on-chain we refreshed "interactively"

@vikiival
Copy link
Member

vikiival commented Jan 11, 2022

I guess subsquid/subquery has some listener for events? cc @vikiival

"Hi, @vikiival! No, it doesn't."

also created issue for rubick kodadot/rubick#20

@yangwao
Copy link
Member

yangwao commented Jan 11, 2022

@yangwao yangwao merged commit c787ac0 into kodadot:main-nuxt Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't render graph until tab is clicked
4 participants