Skip to content

#1749 Fixing transfer and teleport #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 11, 2022
Merged

#1749 Fixing transfer and teleport #1750

merged 6 commits into from
Jan 11, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jan 10, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main-nuxt and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Jan 10, 2022 •
edited
Loading

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 5406a4a

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61dd97b73c8c950008b9cdde

😎 Browse the preview: https://deploy-preview-1750--koda-nuxt.netlify.app

roiLeo
roiLeo suggested changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing:

    this.$store.dispatch('fiat/fetchFiatPrice')

in Transfer.vue & Teleport.vue

console.warn is not rly the best solution to hide the router errors

@prachi00
Copy link
Member Author 

this.$store.dispatch('fiat/fetchFiatPrice')

@roiLeo in transfer and teleport this.$store.dispatch('fetchFiatPrice') this is already there, is this this.$store.dispatch('fiat/fetchFiatPrice') different?

Also, the other way to solve the error is to add an if check comparing current and previous route, I am not sure how to get the previous route in this case tho, since the route is dynamic

@roiLeo
Copy link
Contributor

roiLeo commented Jan 10, 2022 •
edited
Loading

@roiLeo in transfer and teleport this.$store.dispatch('fetchFiatPrice') this is already there, is this this.$store.dispatch('fiat/fetchFiatPrice') different?

  • this.$store.dispatch('fetchFiatPrice') will not work because it will try to disparch action fetchFiatPrice from /store/index
  • this.$store.dispatch('fiat/fetchFiatPrice') will look into /store/fiat & dispatch fetchFiatPrice action

Also, the other way to solve the error is to add an if check comparing current and previous route, I am not sure how to get the previous route in this case tho, since the route is dynamic

I don't have any idea for now, could be fixed with watcher option? we'll leave it like that

roiLeo
roiLeo approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

by the way, random text found in /teleport.vue
Screenshot 2022-01-10 at 17-58-04 #1749 Fixing transfer and teleport by prachi00 · Pull Request #1750 · kodadot nft-gallery

@prachi00
Copy link
Member Author

prachi00 commented Jan 10, 2022 •
edited
Loading

teleport

I have went ahead and removed the random text

@yangwao
Copy link
Member

yangwao commented Jan 10, 2022

can we have it together?

image
image

@prachi00
Copy link
Member Author

can we have it together?

image image

@yangwao should I do this in this PR only or another one? I think it would be better to do it in another one

@prachi00
Copy link
Member Author

can we have it together?
image image

@yangwao should I do this in this PR only or another one? I think it would be better to do it in another one

EDIT: @yangwao decided to do it in this PR only since it was a small css change

Screenshot 2022-01-11 at 1 58 25 PM

roiLeo
roiLeo suggested changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please use layout() like in transfer.vue

@prachi00
Copy link
Member Author

  • transfer.vue

Screenshot 2022-01-11 at 4 18 39 PM

@roiLeo used layout

roiLeo
roiLeo approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yangwao
Copy link
Member

yangwao commented Jan 11, 2022

hey @prachi00 seems doesn't work as the payment link is generating this kind of URL https://undefined.subscan.io/extrinsic/0x7a0addacaff4e14a036fb9255665c311fb6fb4d9cd447a965a654eb33f87dadb :)

can you please take a look?

@prachi00
Copy link
Member Author

hey @prachi00 seems doesn't work as the payment link is generating this kind of URL https://undefined.subscan.io/extrinsic/0x7a0addacaff4e14a036fb9255665c311fb6fb4d9cd447a965a654eb33f87dadb :)

can you please take a look?

@yangwao Have fixed this, working now.

@yangwao
Copy link
Member

yangwao commented Jan 11, 2022

Seems this time it could not generate a link to the transaction
This is what I have in console

image

@prachi00
Copy link
Member Author

@yangwao seems to work fine for me, I tried doing it on local

@yangwao yangwao mentioned this pull request Jan 11, 2022
Closed
@yangwao
Copy link
Member

yangwao commented Jan 11, 2022

okay tested https://kusama.subscan.io/extrinsic/0xd03980f2adbe9fb10d39bbd5777450c7743f23f102604f16331f52aa88e48be4

seems cache... but that warning of navigationduplicated should be solved tho made issue on that for #1769 if you are keen to debug that

@yangwao
Copy link
Member

yangwao commented Jan 11, 2022

Perfect, I’ve sent the payout https://kusama.subscan.io/extrinsic/0x7a0addacaff4e14a036fb9255665c311fb6fb4d9cd447a965a654eb33f87dadb

Let’s grab another issue and get rewarded!
https://github.com/kodadot/nft-gallery/issues/

@yangwao yangwao merged commit 796f034 into kodadot:main-nuxt Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer seems broken on Beta
3 participants
@prachi00 @roiLeo @yangwao