#1635 FEAT: Set Docker image building process #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for koda-nuxt ready! 🔨 Explore the source changes: 7579eb2 🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61d83ed7ae6a3b000864baa9 😎 Browse the preview: https://deploy-preview-1708--koda-nuxt.netlify.app |
atharva3010
changed the title
|
Updated |
|
To publish the image to docker-hub, I'll need to setup an organization repository, and will need to pair with a maintainer. Ping me whenever available. |
|
|
roiLeo
reviewed
Jan 7, 2022
|
@roiLeo Did you do |
|
@roiLeo Thanks for reviewing, I think you raise some valid first time questions and it'll probably be a good idea for me to add comments highlighting why specific steps exist. |
|
2nd test: docker system prune& docker-compose up --build[+] Building 631.5s (12/12) FINISHED Everything work now. |
roiLeo
approved these changes
Jan 7, 2022
|
@roiLeo Glad you got it working! Do note, that building an image is a long process and only needed whenever a new image is fetched. From next time, to run KodaDot, you just need to do: docker-compose up |
|
@atharva3010 when I'm switching branch and try to any idea how to fix this? |
|
@roiLeo You don't need to run Hot module replacement will detect the changes and you'll automatically see the new changes applied. In cases when a new package has been added, docker will error out and you'll have to |
|
|
|
With At least working but still can not access it
|
|
Seems it's listening somewhere
|
|
Do not use the address mentioned by docker, that is not proxied, use |
yup works! perfect! |
|
@yangwao I think the first time contributors will be aware of Regarding "why it is listening to that address", honestly, because it's dockerised and running in a virtual machine. Nuxt being nuxt doesn't detect localhost there and outputs the port with the base address on it. |
|
>>> /wip/nft-gallery #1635 docker compose up --build ✔ 10163 11:45:36
[+] Building 8.1s (12/12) FINISHED
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 241B 0.0s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 81B 0.0s
=> [internal] load metadata for docker.io/library/node:16.13.1-alpine3.14 0.7s
=> [1/7] FROM docker.io/library/node:16.13.1-alpine3.14@sha256:a9b9cb880fa429b0bea899cd3b1bc081ab7277cc97e6d2dcd84bd9753b2027e1 0.0s
=> [internal] load build context 7.1s
=> => transferring context: 106.73MB 7.1s
=> CACHED [2/7] WORKDIR /app 0.0s
=> CACHED [3/7] COPY package.json . 0.0s
=> CACHED [4/7] COPY yarn.lock . 0.0s
=> CACHED [5/7] RUN apk add --no-cache git 0.0s
=> CACHED [6/7] RUN yarn install 0.0s
=> CACHED [7/7] COPY . . 0.0s
=> exporting to image 0.1s
=> => exporting layers 0.0s
=> => writing image sha256:387f8584d66e2694aed5aeb0968ef900fa8083574705fb837c88fba870585f67 0.0s
=> => naming to docker.io/library/nft-gallery_frontend 0.0s
Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
[+] Running 2/2
⠿ Network nft-gallery_default Created 0.1s
⠿ Container Kodadot Created 0.5s
Attaching to Kodadot
Kodadot | yarn run v1.22.15
Kodadot | $ nuxt
Kodadot | /bin/sh: nuxt: not found
Kodadot | error Command failed with exit code 127.
Kodadot | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Kodadot exited with code 127 |
|
Okay, pushed some more changes.
|
|
Perfect! @atharva3010 let's add the KSM address so we can merge it! ;) |
|
@yangwao done! |
|
Perfect, I’ve sent the payout https://kusama.subscan.io/extrinsic/0x7deb276dc5964b973dda2926a3d52f236fc39346830b9232e3f0192111e91237 Let’s grab another issue and get rewarded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.
PR type
Before submitting Pull Request, please make sure:
Optional
What's new?
Had issue bounty label ?
Community participation
Screenshot