Skip to content

#1652 Wider items in feeds #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jan 1, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

Screenshot 2022-01-01 at 3 12 17 PM

@netlify
Copy link

netlify bot commented Jan 1, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 46a6341

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61d2f6ed63e4260007fefc57

😎 Browse the preview: https://deploy-preview-1653--koda-nuxt.netlify.app

@yangwao yangwao requested a review from roiLeo January 1, 2022 13:56
@yangwao
Copy link
Member

yangwao commented Jan 1, 2022

What about

artists profile (all tabs incl), collection detail

Like in collection https://deploy-preview-1653--koda-nuxt.netlify.app/rmrk/collection/3ed709144a55c74945-RICK
image

Artist profile
image

@prachi00
Copy link
Member Author

prachi00 commented Jan 2, 2022

@yangwao I'll check this

@roiLeo
Copy link
Contributor

roiLeo commented Jan 2, 2022

for artist page:
we could try to remove x axis padding on tab-content css class, it will be perfect if we make a rule that can be reused.

@prachi00
Copy link
Member Author

prachi00 commented Jan 3, 2022

@roiLeo please check now, did some changes, also made a common mixin that can be used for tab-content zero x padding.
Let me know if it doesnt seem fine

@roiLeo
Copy link
Contributor

roiLeo commented Jan 3, 2022

why is there no preview?

@prachi00
Copy link
Member Author

prachi00 commented Jan 3, 2022

preview

preview for what?

@yangwao yangwao requested a review from roiLeo January 5, 2022 12:15
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yangwao
Copy link
Member

yangwao commented Jan 5, 2022

@yangwao yangwao merged commit 3af2c31 into kodadot:main-nuxt Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wider items in feeds
3 participants