Skip to content

🖼 refactoring layout #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 2, 2021
Merged

🖼 refactoring layout #1350

merged 10 commits into from
Dec 2, 2021

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Nov 30, 2021

PR type

  • Bugfix
  • Refactoring

What's new?

@netlify
Copy link

netlify bot commented Nov 30, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: ccf7388

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61a8d6c936fc7300087f7f30

😎 Browse the preview: https://deploy-preview-1350--koda-nuxt.netlify.app

@roiLeo roiLeo added the A-nuxt label Nov 30, 2021
@roiLeo roiLeo marked this pull request as draft November 30, 2021 11:03
@roiLeo roiLeo marked this pull request as ready for review November 30, 2021 13:48
@yangwao
Copy link
Member

yangwao commented Nov 30, 2021

Wondering if it saves some build minutes, even little!

@roiLeo roiLeo marked this pull request as draft November 30, 2021 13:55
@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 30, 2021

Wondering if it saves some build minutes, even little!

Sure it will, less files to build.

Found some layout that didn't have full height (Transfer) and need some minor changes. (feel free to test it)

// TODO:

  • landing fix
  • magicbtn weird
  • full height layout

@roiLeo roiLeo marked this pull request as ready for review December 1, 2021 10:18
@@ -120,7 +120,7 @@ body {
color: $primary !important;
}
.navbar-start {
.router-link-active {
.nuxt-link-active {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep quiet, weirdo

@roiLeo roiLeo mentioned this pull request Dec 2, 2021
11 tasks
@yangwao
Copy link
Member

yangwao commented Dec 2, 2021

Screen.Recording.2021-12-02.at.15.13.14.mov

@yangwao yangwao merged commit f04c716 into kodadot:main-nuxt Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Base layout component
2 participants