-
-
Notifications
You must be signed in to change notification settings - Fork 366
fix: install mdi icons locally #11539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe updates involve modifications to the Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Deploying koda-art-prod with
|
Latest commit: |
de58c74
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2f9d9986.kodaart-production.pages.dev |
Branch Preview URL: | https://fix--install-mdi-icons-local.kodaart-production.pages.dev |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
package.json
(1 hunks)pages/drop-checker/[chain]/[collection].vue
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: shard (1, 10)
🔇 Additional comments (5)
package.json (2)
117-117
: Good addition of Material Design Icons package.Adding the
@iconify-json/mdi
package as a local dependency ensures consistent icon rendering between development and production environments. This addresses the issue mentioned in the PR where icons were rendering differently.
120-120
: Appropriate version update for @nuxt/icon.Updating the version constraint from a fixed version to a caret range (
^1.12.0
) allows for compatible minor and patch updates. This is a good practice for keeping dependencies up-to-date while maintaining compatibility.pages/drop-checker/[chain]/[collection].vue (3)
203-203
: Added null check with optional chaining - good defensive coding.Adding optional chaining (
?.
) before callingtoString()
prevents potential errors ifdrop[1]
is null or undefined. This improves the robustness of the code.
209-209
: Added null check with optional chaining - good defensive coding.Similar to the previous change, adding optional chaining prevents errors when rendering the iframe source URL.
215-215
: Improved error handling with optional chaining and default value.This change adds both optional chaining (
?.
) and a fallback empty string (|| ''
) when formatting amounts. This ensures the function receives a valid string even ifdrop[1]
is null or undefined.
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Summary by CodeRabbit
Bug Fixes
Chores