Skip to content

feat: Create select page into modal #11510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2025
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Apr 3, 2025

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image
image

Summary by CodeRabbit

  • New Features

    • Replaced the legacy NFT creation landing page with a streamlined, modal-based interface for selecting creation options.
    • Updated the creation dropdown to open a modal dialog, enhancing navigation and interaction.
    • Revised on-screen instructions and adjusted the supported blockchain networks for asset creation.
    • Introduced a new modal for creating various digital assets, improving user interaction.
  • Style

    • Introduced a new light blue color theme for card elements to enhance the visual appearance.
  • Bug Fixes

    • Adjusted navigation paths for NFT creation to ensure proper routing.
  • Chores

    • Removed deprecated functions and constants to streamline codebase and improve maintainability.

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 3, 2025 21:53
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team April 3, 2025 21:53
Copy link

coderabbitai bot commented Apr 3, 2025

Walkthrough

This pull request overhauls the NFT creation workflow and adjusts related styling and configuration. The previous landing page components have been removed in favor of a modal-driven interaction. Navigation and user authentication flows now leverage modal dialogs that present creation options. Localization files were updated to support the modal content, and new styling variables were introduced for consistent theming. Additionally, testing and utility functions were updated to align with the new control flow and chain management features.

Changes

File(s) Change Summary
components/create/CreateLanding.vue
pages/[prefix]/create/index.vue
Deleted landing page components and associated SEO metadata used for NFT creation.
components/navbar/CreateDropdown.vue Modified navigation: replaced <nuxt-link> with <div>, added and wired up handleButtonClick and isModalActive to trigger a modal instead of direct navigation.
components/create/EntryModal.vue Added a new modal component displaying creation options for NFTs and collections, with click handlers to launch login and redirection flows.
i18n/locales/en.json Removed "landing" text keys and introduced a new "modal" section with revised copy guiding NFT and collection creation.
libs/ui/src/scss/tailwind.scss
libs/ui/tailwind.config.js
Introduced a new CSS variable (--blue-light-cards) and corresponding Tailwind color (blue-light-cards) for light blue card theming.
tests/e2e/createnft.spec.ts Removed the direct navigation constant and updated test steps to interact with elements using test IDs, altering the navigation sequence.
utils/chain.ts
utils/prefix.ts
In chain.ts: Added enableCreateChains and removed popularChains; in prefix.ts: Removed the hasMarketplace function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Dropdown as CreateDropdown
    participant Modal as EntryModal
    participant Auth
    participant Router

    User->>Dropdown: Clicks create option
    Dropdown->>Modal: Triggers handleButtonClick (isModalActive = true)
    Modal->>User: Displays creation options modal
    User->>Modal: Selects a creation option
    Modal->>Auth: Initiates login if required
    Auth-->>Modal: Returns authentication confirmation
    Modal->>Router: Redirects to chosen creation path
Loading

Poem

Oh! I'm a bunny with a skip and a hop,
Watching old pages vanish, never to stop.
A modal now dances with buttons so neat,
Colors of blue make our UI complete.
Code Rabbit cheers with whiskers in play—
Hoppy changes brighten up our day! 🐇💻


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 279f1da and fd41e7b.

📒 Files selected for processing (1)
  • components/create/EntryModal.vue (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit fd41e7b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67f682322353e60008b73774
😎 Deploy Preview https://deploy-preview-11510--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@exezbcz
Copy link
Member

exezbcz commented Apr 6, 2025

image

connect wallet modal when trying to click an item in the wallet connect modal

@Jarsen136
Copy link
Contributor Author

image connect wallet modal when trying to click an item in the wallet connect modal

It's fixed here but not merged yet #11509

@exezbcz
Copy link
Member

exezbcz commented Apr 6, 2025

oki, then it works, thanks!

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@Jarsen136 Jarsen136 enabled auto-merge April 9, 2025 14:12
Copy link

sonarqubecloud bot commented Apr 9, 2025

@Jarsen136 Jarsen136 added this pull request to the merge queue Apr 10, 2025
Merged via the queue into kodadot:main with commit 4af44c0 Apr 10, 2025
27 checks passed
@Jarsen136 Jarsen136 deleted the issue-11506 branch April 10, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create select page into modal
4 participants