Skip to content

ci: adjust retry config for e2e #11449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Feb 26, 2025

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • sometimes there is some flaky test in the CI. should we increase the retry limit?

for example on my PR, at 1st attemp it fails in some test: https://github.com/kodadot/nft-gallery/actions/runs/13542598738/attempts/1?pr=11448

after retry the test, it just works: https://github.com/kodadot/nft-gallery/actions/runs/13542598738?pr=11448

Summary by CodeRabbit

  • Tests
    • Increased the number of retry attempts in continuous integration, enhancing the stability and robustness of automated tests during CI runs.

Copy link

cloudflare-workers-and-pages bot commented Feb 26, 2025

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 643a179
Status:⚡️  Build in progress...

View logs

Copy link

coderabbitai bot commented Feb 26, 2025

Walkthrough

The change updates the Playwright configuration by modifying the number of test retries. When the CI environment variable is set to true, the test runner now allows 3 retries instead of the previous 1, while keeping retries at 0 otherwise. This adjustment aims to enhance the robustness of tests in continuous integration environments.

Changes

File Change Summary
playwright.config.ts Updated retries configuration from process.env.CI ? 1 : 0 to process.env.CI ? 3 : 0.

Sequence Diagram(s)

sequenceDiagram
    participant Env as Environment Variable
    participant Runner as Test Runner

    Runner->>Env: Check if CI is true
    alt CI true
        Env-->>Runner: Yes, CI enabled
        Runner->>Runner: Apply retries = 3
    else CI false
        Env-->>Runner: No, CI disabled
        Runner->>Runner: Apply retries = 0
    end
    Runner->>Runner: Execute tests with configured retry count
Loading

Poem

I'm a rabbit in the code field, full of cheer,
Hopping through tests with retries now clear,
From one hop to three when CI's in flight,
Leaping over failures with delight,
Here's to changes hopped in—happy coding, my friend!
🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between ad74a50 and 643a179.

📒 Files selected for processing (1)
  • playwright.config.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • playwright.config.ts

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for polkadot ready!

Name Link
🔨 Latest commit 3d637f9
🔍 Latest deploy log https://app.netlify.com/sites/polkadot/deploys/67befcb8c3c1bc0008a6f6b0
😎 Deploy Preview https://deploy-preview-11449--polkadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 643a179
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67c981d35584c6000885ecd9
😎 Deploy Preview https://deploy-preview-11449--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@preschian preschian marked this pull request as ready for review February 26, 2025 11:50
@preschian preschian requested a review from a team as a code owner February 26, 2025 11:50
@preschian preschian requested review from vikiival and Jarsen136 and removed request for a team February 26, 2025 11:50
@preschian preschian enabled auto-merge March 3, 2025 07:26
@preschian preschian added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit f860423 Mar 6, 2025
20 of 25 checks passed
@preschian preschian deleted the ci--adjust-retry-config-for-e2e branch March 6, 2025 11:07
Copy link

sonarqubecloud bot commented Mar 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants