fix: mobile modal #11442

Jarsen136 · 2025-02-25T09:17:34Z

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix

Needs Design check

@exezbcz please review

Needs QA check

@kodadot/qa-guild please review

Context

Closes Remove top margin from modals on mobile #11438

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

Summary by CodeRabbit

Style
- Relaxed modal height restrictions to allow content areas to expand, providing a more flexible viewing experience.
- Updated modal defaults to utilize full viewport height for improved content display and seamless scrolling.

coderabbitai · 2025-02-25T09:17:46Z

Walkthrough

Several modal components have been updated to adjust their height constraints. Two modals had their fixed maximum heights removed by deleting a dedicated property and CSS class, allowing for more flexible content display. In addition, the default maximum height for another modal component was revised from 80% to 100% of the viewport height. There were no changes to any component logic or public exports.

Changes

Files	Change Summary
`components/.../ListingCartModal.vue` `components/.../MakeOfferModal.vue`	Removed the `modal-max-height` attribute from the ModalBody component and the `max-h-[50vh]` class from surrounding divs. (The MakeOfferModal still retains the `overflow-y-auto` class.)
`libs/ui/src/.../NeoModal.vue`	Updated the default `maxHeight` prop from `'80vh'` to `'100vh'`, thereby allowing the modal to span the full viewport height.

Poem

I’m a rabbit with a skip so light,
Hopping through modals in the digital night.
Heights extend where limits once lay,
Bringing boundless views to brighten the day.
With whiskers twitching in ASCII delight!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a87a950 and fd5b51f.

📒 Files selected for processing (3)

components/common/listingCart/ListingCartModal.vue (1 hunks)
components/trade/makeOffer/MakeOfferModal.vue (1 hunks)
libs/ui/src/components/NeoModal/NeoModal.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (19)

GitHub Check: Redirect rules
GitHub Check: Header rules
GitHub Check: Pages changed
GitHub Check: Redirect rules
GitHub Check: Header rules
GitHub Check: Pages changed
GitHub Check: shard (10, 10)
GitHub Check: shard (9, 10)
GitHub Check: shard (8, 10)
GitHub Check: shard (7, 10)
GitHub Check: shard (6, 10)
GitHub Check: shard (5, 10)
GitHub Check: shard (4, 10)
GitHub Check: build-cf
GitHub Check: shard (3, 10)
GitHub Check: shard (2, 10)
GitHub Check: build
GitHub Check: runner / eslint
GitHub Check: shard (1, 10)

🔇 Additional comments (3)

libs/ui/src/components/NeoModal/NeoModal.vue (1)

64-64: Increased modal height will improve mobile user experience.

Changing the default maxHeight from 80vh to 100vh allows modals to utilize the full viewport height, which should help resolve the mobile modal issues mentioned in the PR.

components/common/listingCart/ListingCartModal.vue (1)

42-42: Removal of height constraint improves content display on mobile.

Removing the max-h-[50vh] class from this div allows its content to expand naturally without the previous 50% viewport height limitation, which should help address the mobile modal issues mentioned in the PR objectives.

components/trade/makeOffer/MakeOfferModal.vue (1)

25-25: Removal of height constraint improves content display on mobile.

Removing the max-h-[50vh] class from this div allows its content to expand naturally without the previous 50% viewport height limitation, which should help address the mobile modal issues mentioned in the PR objectives.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-25T09:17:56Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`fd5b51f`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/67bd8ab3309d340008dec4f9
😎 Deploy Preview	https://deploy-preview-11442--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-02-25T09:17:56Z

✅ Deploy Preview for polkadot ready!

Name	Link
🔨 Latest commit	`fd5b51f`
🔍 Latest deploy log	https://app.netlify.com/sites/polkadot/deploys/67bd8ab31191cb000830c2c5
😎 Deploy Preview	https://deploy-preview-11442--polkadot.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sonarqubecloud · 2025-02-25T09:18:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

hassnian

@Jarsen136 a test is failing , unrelated ?

Jarsen136 · 2025-02-26T10:12:19Z

@Jarsen136 a test is failing , unrelated ?

It's unrelated to current PR

fix: mobile modal

fd5b51f

Jarsen136 requested a review from a team as a code owner February 25, 2025 09:17

Jarsen136 requested review from preschian and hassnian and removed request for a team February 25, 2025 09:17

preschian approved these changes Feb 25, 2025

View reviewed changes

hassnian approved these changes Feb 26, 2025

View reviewed changes

Jarsen136 added this pull request to the merge queue Feb 26, 2025

Merged via the queue into kodadot:main with commit ad74a50 Feb 26, 2025
27 checks passed

Jarsen136 deleted the issue-11438 branch February 26, 2025 14:26

coderabbitai bot mentioned this pull request Mar 19, 2025

fix: unity nft mint fee #11494

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: mobile modal #11442

fix: mobile modal #11442

Uh oh!

Jarsen136 commented Feb 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 25, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

netlify bot commented Feb 25, 2025 •

edited

Loading

Uh oh!

netlify bot commented Feb 25, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Feb 25, 2025

Uh oh!

hassnian left a comment

Uh oh!

Jarsen136 commented Feb 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: mobile modal #11442

fix: mobile modal #11442

Uh oh!

Conversation

Jarsen136 commented Feb 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Needs Design check

Needs QA check

Context

Screenshot 📸

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

netlify bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for koda-canary ready!

Uh oh!

netlify bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for polkadot ready!

Uh oh!

sonarqubecloud bot commented Feb 25, 2025

Quality Gate passed

Uh oh!

hassnian left a comment

Choose a reason for hiding this comment

Uh oh!

Jarsen136 commented Feb 26, 2025

Uh oh!

Uh oh!

Uh oh!

Jarsen136 commented Feb 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 25, 2025 •

edited

Loading

netlify bot commented Feb 25, 2025 •

edited

Loading