refactor: reduce bulma usages #11428

preschian · 2025-02-19T11:53:47Z

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

ref: remove bulma css #9013

Summary by CodeRabbit

Style
- Enhanced responsive behavior across various views for a more consistent mobile, tablet, and desktop experience.
- Updated visual effects such as hover and selection cues for improved clarity.
- Refined typography and layout on the blog page for better readability.
Chores
- Streamlined styling by shifting to a unified design framework, ensuring a more maintainable and coherent visual presentation.

…mponent

…ve mixins

coderabbitai · 2025-02-19T11:53:56Z

Walkthrough

This pull request implements a series of style updates across the codebase. New Bulma breakpoint mixins and their variants have been added, and many components have been updated to replace generic mixins and SCSS variable imports with Bulma-specific ones. Several files now use standard CSS media queries in place of custom mixin-based queries, and some CSS properties have been adjusted to use CSS custom properties. Additionally, a typographical correction was made in the blog page headline. None of these changes affect component functionality; they update the styling framework and responsive design strategy.

Changes

File(s)	Change Summary
`assets/styles/abstracts/_mixins.scss`	Added new Bulma breakpoint mixins (`bulma-mobile`, `bulma-tablet`, `bulma-touch`, `bulma-desktop`, `bulma-widescreen`, `bulma-fullhd`) along with `-only` and `until-` variants; added deprecation notice advising against use for new components in favor of Tailwind breakpoints.
`assets/styles/components/_content-markdown.scss`, `components/shared/DragDrop.vue`, `components/shared/modals/ModalBody.vue`, `components/shared/view/InfoBox.vue`, `components/transfer/TransferConfirmModal.vue`	Removed SCSS variables import statements.
`components/common/autoTeleportWelcomeModal.vue`, `components/massmint/OnBoarding.vue`, `components/massmint/OnBoardingCard.vue`, `components/teleport/Teleport.vue`, `components/teleport/TeleportTabs.vue`, `components/transfer/Transfer.vue`, `pages/blog/index.vue`	Replaced SCSS variables import with mixins import and updated mixin calls (e.g., `mobile`, `touch`, `tablet`) to Bulma-specific variants; in Teleport.vue and blog index, replaced mixin-based media queries with standard CSS media queries; blog index also had a typographical correction.
`components/collection/unlockable/ImageSlider.vue`	Updated mixin calls by replacing generic `mobile` and `tablet-only` with `bulma-mobile` and `bulma-tablet-only` for responsive design.
`components/shared/view/SelectableImage.vue`	Updated border styles to use CSS custom properties instead of SCSS variables.
`libs/ui/src/scss/tailwind.scss`	Consolidated the CSS variable `--toggle-active-switch` by removing its duplicate declaration in the `.dark` context.

Suggested reviewers

Jarsen136
hassnian
vikiival

Poem

I'm a little rabbit on a coding spree,
Hopping through mixins, as spry as can be.
With Bulma leaps replacing old SCSS ties,
I nibble on updates under clear blue skies.
Changes prance lightly—style refreshed and bright,
A joyful PR that fills my heart with delight!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a87a950 and b785ea2.

📒 Files selected for processing (16)

assets/styles/abstracts/_mixins.scss (1 hunks)
assets/styles/components/_content-markdown.scss (0 hunks)
components/collection/unlockable/ImageSlider.vue (1 hunks)
components/common/autoTeleport/AutoTeleportWelcomeModal.vue (2 hunks)
components/massmint/OnBoarding.vue (3 hunks)
components/massmint/OnBoardingCard.vue (2 hunks)
components/shared/DragDrop.vue (0 hunks)
components/shared/modals/ModalBody.vue (0 hunks)
components/shared/view/InfoBox.vue (0 hunks)
components/shared/view/SelectableImage.vue (1 hunks)
components/teleport/Teleport.vue (5 hunks)
components/teleport/TeleportTabs.vue (1 hunks)
components/transfer/Transfer.vue (1 hunks)
components/transfer/TransferConfirmModal.vue (0 hunks)
libs/ui/src/scss/tailwind.scss (0 hunks)
pages/blog/index.vue (6 hunks)

💤 Files with no reviewable changes (6)

assets/styles/components/_content-markdown.scss
components/shared/modals/ModalBody.vue
components/shared/view/InfoBox.vue
components/shared/DragDrop.vue
components/transfer/TransferConfirmModal.vue
libs/ui/src/scss/tailwind.scss

✅ Files skipped from review due to trivial changes (2)

components/teleport/TeleportTabs.vue
components/transfer/Transfer.vue

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: shard (10, 10)
GitHub Check: shard (6, 10)
GitHub Check: shard (4, 10)
GitHub Check: shard (1, 10)
GitHub Check: Cloudflare Pages: koda-art-prod

🔇 Additional comments (30)

components/shared/view/SelectableImage.vue (2)

35-35: Border color updated to use CSS custom property.

The change replaces SCSS variable $link with CSS custom property var(--k-blue) for the selected state border styling.

38-38: Border color updated to use CSS custom property.

The change replaces SCSS variable $link-light with CSS custom property var(--k-blue-light) for the hover state border styling.

components/common/autoTeleport/AutoTeleportWelcomeModal.vue (2)

96-96: Updated import from variables to mixins.

The import statement has been updated to use Bulma mixins rather than variables, aligning with the PR objective to refactor Bulma usage.

108-108: Updated responsive mixin to use Bulma-specific prefix.

The mixin has been renamed from @include mobile to @include bulma-mobile to make the Bulma dependency explicit.

components/collection/unlockable/ImageSlider.vue (2)

110-110: Added mixins import.

Added import for SCSS mixins, necessary for the Bulma responsive breakpoint mixins used throughout the file.

117-122: Updated responsive mixins to use Bulma-specific prefixes.

All responsive design mixins have been updated to use the bulma- prefix (e.g., @include mobile → @include bulma-mobile, @include tablet-only → @include bulma-tablet-only). This change makes Bulma dependencies explicit and helps isolate the framework's usage.

Also applies to: 123-126, 134-138, 145-149, 150-154, 161-165, 166-170, 175-178

components/massmint/OnBoarding.vue (2)

193-193: Updated import to use mixins.

Changed the import statement to use mixins instead of variables, consistent with the pattern in other files.

214-217: Updated responsive mixins to use Bulma-specific prefixes.

The responsive mixins have been updated from generic names to Bulma-specific ones:

@include mobile → @include bulma-mobile

@include touch → @include bulma-touch

This makes the Bulma dependency explicit and helps in the PR's goal of refactoring Bulma usage.

Also applies to: 238-242, 246-251

components/massmint/OnBoardingCard.vue (3)

32-32: Stylesheet import update for responsive design.

The import statement has been updated to use mixins instead of variables, which aligns with the PR objective to refactor Bulma usage.

39-41: Updated to Bulma-specific mobile mixin.

The generic mobile mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

51-53: Updated to Bulma-specific tablet mixin.

The generic tablet mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

components/teleport/Teleport.vue (11)

527-527: Stylesheet import update for responsive design.

The import statement has been updated to use mixins instead of variables, aligning with the PR objective to refactor Bulma usage.

531-534: Replaced mixin with standard media query.

The custom until mixin has been replaced with a standard CSS media query. This maintains the same responsive behavior while reducing dependency on Bulma mixins.

540-542: Replaced mixin with standard media query.

The custom until mixin has been replaced with a standard CSS media query. This maintains the same responsive behavior while reducing dependency on Bulma mixins.

546-550: Updated to Bulma-specific tablet mixin.

The generic tablet mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

552-555: Updated to Bulma-specific mobile mixin.

The generic mobile mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

561-563: Replaced mixin with standard media query.

The custom until mixin has been replaced with a standard CSS media query. This maintains the same responsive behavior while reducing dependency on Bulma mixins.

567-570: Updated to Bulma-specific tablet mixin.

The generic tablet mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

572-575: Updated to Bulma-specific mobile mixin.

The generic mobile mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

589-591: Updated to Bulma-specific tablet mixin.

The generic tablet mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

593-608: Updated to Bulma-specific mobile mixin and CSS variables.

The generic mobile mixin has been replaced with the Bulma-specific version. Additionally, the background color now uses CSS variables instead of SCSS variables, which enhances theme consistency.

614-614: Updated to use CSS variable for background color.

The color now uses a CSS variable instead of an SCSS variable, which enhances theme consistency and supports potential dark mode implementations.

pages/blog/index.vue (7)

8-8: Fixed typographical error in headline text.

Corrected the headline text to have proper capitalization in "Let's Explore The NFT Universe".

149-149: Stylesheet import update for responsive design.

The import statement has been updated to use mixins instead of variables, aligning with the PR objective to refactor Bulma usage.

168-177: Updated to Bulma-specific touch mixin.

The generic touch mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

226-228: Updated to Bulma-specific touch mixin.

The generic touch mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

244-246: Replaced mixin with standard media query.

The custom until mixin has been replaced with a standard CSS media query. This maintains the same responsive behavior while reducing dependency on Bulma mixins.

248-250: Replaced mixin with standard media query.

The custom until mixin has been replaced with a standard CSS media query. This maintains the same responsive behavior while reducing dependency on Bulma mixins.

294-312: Updated to Bulma-specific touch mixin.

The generic touch mixin has been replaced with the Bulma-specific version, maintaining the same responsive behavior while standardizing the approach.

assets/styles/abstracts/_mixins.scss (1)

30-76: Added Bulma-specific breakpoint mixins with deprecation notice.

This addition creates a clear transition path from generic mixins to Bulma-specific ones, while also signaling the intended move toward Tailwind breakpoints for new components. The well-documented mixins include:

Bulma breakpoint mixins (mobile, tablet, touch, etc.)

"-only" variants for specific ranges

"until-" variants for upper bounds

The deprecation notice is particularly valuable for ensuring consistent styling in future development.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-19T11:54:06Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`b785ea2`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/67bdc305c341f80008088697
😎 Deploy Preview	https://deploy-preview-11428--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2025-02-19T11:56:00Z

Deploying koda-art-prod with Cloudflare Pages

Latest commit:	`b785ea2`
Status:	✅ Deploy successful!
Preview URL:	https://af158ca6.kodaart-production.pages.dev
Branch Preview URL:	https://refactor--reduce-bulma-usage.kodaart-production.pages.dev

View logs

netlify · 2025-02-25T13:18:11Z

✅ Deploy Preview for polkadot ready!

Name	Link
🔨 Latest commit	`b785ea2`
🔍 Latest deploy log	https://app.netlify.com/sites/polkadot/deploys/67bdc305190eda0008733ba5
😎 Deploy Preview	https://deploy-preview-11428--polkadot.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sonarqubecloud · 2025-02-25T13:18:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

preschian added 10 commits February 19, 2025 17:33

feat(ui): add responsive mixins for bulma breakpoints

cdc4b55

style(markdown): remove unused import statement from styles

3c694c5

style(massmint): update mixins and color definitions in onboarding co…

f321159

…mponent

style(ui): remove unused Bulma mixins from tailwind.scss

1823162

style(massmint): replace mixins with media queries for responsiveness

f6bc976

feat(styles): add Bulma breakpoint mixins and integrate into components

e9b6b58

style(autoTeleport): update stylesheet to use mixins and bulma-mobile

40f5e45

docs(styles): add deprecation notice for Bulma breakpoints mixins

b1567e0

style(scss): replace variables import with mixins and adjust responsi…

eb2af90

…ve mixins

style(selectable-image): replace SCSS variables with CSS variables

711f897

Base automatically changed from refactor--deprecate-ktheme-usages-(3) to main February 21, 2025 18:16

Merge branch 'main' into refactor--reduce-bulma-usages

b785ea2

preschian marked this pull request as ready for review February 25, 2025 13:17

preschian requested a review from a team as a code owner February 25, 2025 13:17

preschian requested review from Jarsen136 and hassnian and removed request for a team February 25, 2025 13:17

Jarsen136 approved these changes Feb 26, 2025

View reviewed changes

hassnian approved these changes Feb 26, 2025

View reviewed changes

preschian added this pull request to the merge queue Mar 3, 2025

Merged via the queue into main with commit 5476b3e Mar 3, 2025
25 of 27 checks passed

preschian deleted the refactor--reduce-bulma-usages branch March 3, 2025 07:27

coderabbitai bot mentioned this pull request Mar 3, 2025

🔧 .container.is-fluid to tailwind #11391

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: reduce bulma usages #11428

refactor: reduce bulma usages #11428

Uh oh!

preschian commented Feb 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 19, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

netlify bot commented Feb 19, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Feb 19, 2025 •

edited

Loading

Uh oh!

netlify bot commented Feb 25, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Feb 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

refactor: reduce bulma usages #11428

refactor: reduce bulma usages #11428

Uh oh!

Conversation

preschian commented Feb 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Context

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

netlify bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for koda-canary ready!

Uh oh!

cloudflare-workers-and-pages bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying koda-art-prod with Cloudflare Pages

Uh oh!

netlify bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for polkadot ready!

Uh oh!

sonarqubecloud bot commented Feb 25, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

preschian commented Feb 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 19, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 19, 2025 •

edited

Loading

netlify bot commented Feb 25, 2025 •

edited

Loading