Skip to content

feat: Action Buttons: Implement Counter-swap Functionality #11291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 2, 2025

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Dec 24, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

@exezbcz visual check pls, dont merge without it, thanks

Screenshot 📸

  • My fix has changed something on UI;

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2ab1cff
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/676aba345c9b6d0008c82095
😎 Deploy Preview https://deploy-preview-11291--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4e6cead
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6774a9920815e20008f110f8
😎 Deploy Preview https://deploy-preview-11291--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as ready for review December 28, 2024 11:17
@hassnian hassnian requested a review from a team as a code owner December 28, 2024 11:17
@hassnian hassnian requested review from vikiival, Jarsen136 and preschian and removed request for a team and vikiival December 28, 2024 11:17
@exezbcz
Copy link
Member

exezbcz commented Dec 28, 2024

What does the button open? I assume that it's the swap UI with predefined items.

otherwise looks good

@hassnian
Copy link
Contributor Author

What does the button open? I assume that it's the swap UI with predefined items.

yes

Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for polkadot ready!

Name Link
🔨 Latest commit 4e6cead
🔍 Latest deploy log https://app.netlify.com/sites/polkadot/deploys/6774a9920a013b0008638023
😎 Deploy Preview https://deploy-preview-11291--polkadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 15
Accessibility: 83
Best Practices: 83
SEO: 81
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival
Copy link
Member

this deploy preview seems to work

Copy link

sonarqubecloud bot commented Jan 1, 2025

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING! 🤩

@vikiival vikiival added this pull request to the merge queue Jan 2, 2025
Merged via the queue into kodadot:main with commit a1ca013 Jan 2, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants