Skip to content

add update method to Record class #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add update method to Record class #270

wants to merge 1 commit into from

Conversation

evstratbg
Copy link

add update domain record support

@evstratbg
add update method to Record class
18adf28 
add update domain record support
@koalalorenzo
Copy link
Owner

Do we have tests?

@wacuuu wacuuu mentioned this pull request Oct 4, 2019
Closed
koalalorenzo
koalalorenzo requested changes Jan 20, 2020
View reviewed changes
Copy link
Owner

@koalalorenzo koalalorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing

@evstratbg
Copy link
Author

evstratbg commented Jan 20, 2020 •
edited
Loading

Oops, gonna code it this week

@evstratbg
Copy link
Author

There is no tests for Record class. Should I implement this?

@koalalorenzo
Copy link
Owner

koalalorenzo commented Feb 19, 2020 •
edited
Loading

Yes that would be nice! Check how it has been done in other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koalalorenzo koalalorenzo koalalorenzo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
missing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evstratbg @koalalorenzo