Patch Google Drive #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Google Spreadsheet chooser was previously limited to finding files within the user's "My Drive". This prevented users from selecting spreadsheets stored in Shared Drives, which is a critical feature for collaborative team environments.
This commit updates the Drive API file list request by adding the required parameters to search across all corpora:
- setCorpora("allDrives")
- setIncludeItemsFromAllDrives(true)
- setSupportsAllDrives(true)
As a result, the file chooser dialog can now discover and list spreadsheets from both "My Drive" and any Shared Drives the user has access to.
The file listing methods (`getFilesByNameOrIdImpl` and `listParentImpl`) only configured the API query to include all drives when a specific `driveId` was provided. When `driveId` was null (e.g., when searching in "My Drive"), the query lacked the necessary parameters (`corpora`, `includeItemsFromAllDrives`, `supportsAllDrives`). This resulted in searches failing to find files located in Shared Drives if the search was not scoped to a specific drive. This commit adds a new helper method `addSearchAllDrivesToQuery` and calls it in the `else` block of the list methods. This ensures that all file listing queries are correctly configured to search across all drives (My Drive and Shared Drives) the user has access to, making the file discovery robust and complete.
Patch Google Drive
The Google Drive API requires the `corpora` parameter to be set to `drive` when a specific `driveId` is provided for searching within a Shared Drive. The previous implementation incorrectly set `corpora` to `allDrives` in this context, causing a 403 error due to the parameter conflict. This commit corrects the value to `drive`, resolving the API error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.