NXT-4251: New endpoint to retrieve the ancestor info #6
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new endpoint to retrieve ancestor information for a space item, addressing an issue where "Reveal in explorer" functionality was not working correctly after component sharing in the browser. The implementation includes handling for potentially outdated project names by returning the current item name and providing informative error messages when the item may have been deleted remotely.
Key Changes:
- Added
getAncestorInfomethod to retrieve ancestor item IDs and current item name - Implemented error handling with context-aware messages for remote item changes or deletions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| final var itemName = space.getItemName(itemId); | ||
| return builder(AncestorInfoEntBuilder.class).setItemName(itemName).setAncestorItemIds(ancestorItemIds) | ||
| .build(); | ||
| } catch (MutableServiceCallException e) { // NOSONAR |
There was a problem hiding this comment.
The NOSONAR comment suppresses warnings but lacks explanation. Add a brief comment explaining why this exception handling pattern is intentional, such as why the exception is caught and rethrown with additional context.
| final var projectName = m_projectManager // | ||
| .getProject(providerId, spaceId, itemId) // | ||
| .map(Project::getName) // | ||
| .orElse("the project"); |
There was a problem hiding this comment.
The fallback error message 'the project' is vague when the project name cannot be determined. Consider using a more descriptive fallback like 'the requested project' or 'project (unknown name)' to make it clearer to users that the specific project name is unavailable.
| .orElse("the project"); | |
| .orElse("project (unknown name)"); |
... for a space item. NXT-4251 ('Reveal in explorer' after component sharing in browser does not work)
hornm-knime
force-pushed
the
bug/NXT-4251-reveal-in-explorer-after-compon
branch
from
7e68182 to
e851f70
Compare
|
... for a space item.
NXT-4251 ('Reveal in explorer' after component sharing in browser does not work)