-
Notifications
You must be signed in to change notification settings - Fork 159
AP-25387: Remove deprecated HubItemVersion in favor of ItemVersion #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the deprecated HubItemVersion class and related deprecated types (LinkType, HubItemVersionPersistor), replacing their usage with the newer ItemVersion API. The deprecated classes are hollowed out to throw UnsupportedOperationException while maintaining their API surface for backward compatibility until complete removal.
Key changes:
- Refactored
URLResolverUtilto useItemVersion.match()andItemVersion.convertToItemVersion()instead of internal pattern matching logic - Updated
ItemVersionStringPersistorto use static factory methods fromItemVersion - Replaced all test and production code references from
HubItemVersiontoItemVersion
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| URLResolverUtil.java | Removed internal matching methods and unused imports; simplified version handling using ItemVersion's built-in methods |
| ItemVersionStringPersistor.java | Updated to use ItemVersion static factory methods instead of direct class instantiation |
| HubItemVersionPersistor.java | Hollowed out to throw UnsupportedOperationException in all methods |
| HubItemVersion.java | Hollowed out to throw UnsupportedOperationException in all methods |
| TemplateUpdateUtil.java | Hollowed out LinkType enum to throw UnsupportedOperationException |
| MetaNodeTemplateInformation.java | Replaced HubItemVersion usage with URLResolverUtil.parseVersion and ItemVersion |
| URLMethodSources.java | Updated test data from HubItemVersion to ItemVersion |
| ServerExecutorUrlResolverTest.java | Updated test parameters from HubItemVersion to ItemVersion |
| RemoteExecutorUrlResolverTest.java | Replaced HubItemVersion method calls with ItemVersion equivalents |
| HubExecutorUrlResolverTest.java | Replaced HubItemVersion.of() with URLResolverUtil.parseVersion() |
| AnalyticsPlatformTempCopyUrlResolverTest.java | Updated test parameters from HubItemVersion to ItemVersion |
| AnalyticsPlatformLocalUrlResolverTest.java | Updated test parameters from HubItemVersion to ItemVersion |
| HubItemVersionTest.java | Deleted entire test file as the class is deprecated |
| HubItemVersionPersistorTest.java | Deleted entire test file as the class is deprecated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
org.knime.core/src/eclipse/org/knime/core/util/urlresolve/URLResolverUtil.java
Show resolved
Hide resolved
org.knime.core/src/eclipse/org/knime/core/node/workflow/TemplateUpdateUtil.java
Show resolved
Hide resolved
0792ca5 to
ff03033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
org.knime.core/src/eclipse/org/knime/core/util/urlresolve/URLResolverUtil.java
Show resolved
Hide resolved
ff03033 to
47162c2
Compare
* Remove all mentions of HubItemVersion, LinkType, and HubItemVersionPersistor. * Hollow-out these classes to keep API, but always throw UOEs. * Replace occurences by the `org.knime.core.util.hub.ItemVersion`. * See URLResolverUtil for many convenient utilities. AP-25387 (Remove deprecated `HubItemVersion` and its `LinkType`)
47162c2 to
4f27f74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
org.knime.core/src/eclipse/org/knime/core/util/urlresolve/URLResolverUtil.java
Show resolved
Hide resolved
org.knime.core/src/eclipse/org/knime/core/node/workflow/TemplateUpdateUtil.java
Show resolved
Hide resolved
|




org.knime.core.util.hub.ItemVersion.AP-25387 (Remove deprecated
HubItemVersionand itsLinkType)