UIEXT-1663: Adapt color model range to work with color gradient designer #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request implements a Color Gradient Designer feature for the KNIME Color Manager, enabling support for:
- Multiple stop values/colors with CIELab color space interpolation
- Predefined color gradients (matplotlib/ColorBrewer palettes)
- Special color handling for edge cases (NaN, infinity, missing values)
- Percentage-based and absolute value stop configurations
Key changes:
- New color space conversion utilities for sRGB/Hex/CIELab transformations
- Enhanced ColorModelRange to support gradient-based color models
- Predefined color gradient definitions from matplotlib and ColorBrewer
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ColorSpaceConversionUtil.java | Utility class for color space conversions between sRGB, Hex, and CIELab |
| ColorModelRange.java | Extended to support multiple stop values, special colors, and gradient-based interpolation |
| ColorGradientDefinitionUtil.java | Constant definitions for predefined color gradients from matplotlib and ColorBrewer |
| ColorGradient.java | Enum defining available color gradient options |
| ColorSpaceConversionUtilTest.java | Test coverage for color space conversion utilities |
| ColorModelRangeTest.java | Expanded test coverage for new ColorModelRange functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
org.knime.core/src/eclipse/org/knime/core/data/property/ColorModelRange.java
Outdated
Show resolved
Hide resolved
org.knime.core/src/eclipse/org/knime/core/data/property/ColorModelRange.java
Outdated
Show resolved
Hide resolved
org.knime.core/src/eclipse/org/knime/core/data/property/ColorModelRange.java
Outdated
Show resolved
Hide resolved
org.knime.core/src/eclipse/org/knime/core/data/property/ColorModelRange.java
Outdated
Show resolved
Hide resolved
org.knime.core/src/eclipse/org/knime/core/data/property/ColorModelRange.java
Outdated
Show resolved
Hide resolved
org.knime.core/src/eclipse/org/knime/core/data/property/ColorModelRange.java
Outdated
Show resolved
Hide resolved
org.knime.core/src/eclipse/org/knime/core/data/property/ColorModelRange.java
Outdated
Show resolved
Hide resolved
org.knime.core/src/eclipse/org/knime/core/data/property/ColorModelRange.java
Outdated
Show resolved
Hide resolved
- Add support for special colors - Add support for predefined gradients - Add support for custom gradients with multiple stop values/colors - Add possibility to apply model (similar to model nominal) - Add color conversion utility - Interpolate using lab for new models/use rgb interpolation for color manager UIEXT-1663 (Web UI for Color Manager - Color Gradient Designer)
- constuctor for predefined gradients should not be used for custom gradients - applied models should not be applied a second time UIEXT-1663 (Web UI for Color Manager - Color Gradient Designer)
robin-gerling
force-pushed
the
enh/UIEXT-1663-web-ui-for-color-manager-color-gradient-designer
branch
from
08646a9 to
de1907a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
org.knime.core/src/eclipse/org/knime/core/data/property/ColorModelRange2.java:1
- Corrected spelling of 'testThrowsWhenStopValuesAreNotSortedNonDecreasing'. The word 'Descreasing' should be 'Decreasing'.
/*
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robin-gerling
force-pushed
the
enh/UIEXT-1663-web-ui-for-color-manager-color-gradient-designer
branch
2 times, most recently
from
aac465d to
c358078
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
UIEXT-1663 (Web UI for Color Manager - Color Gradient Designer)
robin-gerling
force-pushed
the
enh/UIEXT-1663-web-ui-for-color-manager-color-gradient-designer
branch
from
c358078 to
62d01c3
Compare
|
PaulBrnrther
deleted the
enh/UIEXT-1663-web-ui-for-color-manager-color-gradient-designer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIEXT-1663 (Web UI for Color Manager - Color Gradient Designer)