Skip to content

Fix min-scale transition #16094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 29, 2025
Merged

Fix min-scale transition #16094

merged 7 commits into from
Sep 29, 2025

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Sep 22, 2025 •
edited
Loading

  • adjust revisionfailure test image to allow changing the state of the pod
  • include test to ensure min-scale transition works as expected

Fixes of #15889

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 22, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.18%. Comparing base (e85e3f6) to head (bf19602).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/testing/v1/configuration.go 0.00% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16094      +/-   ##
==========================================
+ Coverage   80.14%   80.18%   +0.03%     
==========================================
  Files         214      214              
  Lines       16877    16893      +16     
==========================================
+ Hits        13526    13545      +19     
- Misses       2989     2990       +1     
+ Partials      362      358       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2025
@dprotaso
Copy link
Member Author

Pushed a fix

@dprotaso dprotaso mentioned this pull request Sep 22, 2025
Closed
@dprotaso
Copy link
Member Author

Interesting - the new test is reporting that the first revision is reporting Ready=True before min-scale is reached.

@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

4 similar comments
@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

@dprotaso dprotaso changed the title [wip] Fix min-scale transition Fix min-scale transition Sep 25, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2025
@dprotaso
Copy link
Member Author

@houshengbo @nader-ziada this is ready for a review

@nader-ziada
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
@knative-prow knative-prow bot merged commit 0902825 into knative:main Sep 29, 2025
69 checks passed
@dprotaso dprotaso deleted the fix-min-scale branch September 29, 2025 16:50
@dprotaso
Copy link
Member Author

/cherry-pick release-1.19
/cherry-pick release-1.18

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #16100

In response to this:

/cherry-pick release-1.19
/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Sep 29, 2025
Open
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #16101

In response to this:

/cherry-pick release-1.19
/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Sep 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@gauron99 gauron99 Awaiting requested review from gauron99

@skonto skonto Awaiting requested review from skonto

Assignees

@houshengbo houshengbo

@nader-ziada nader-ziada

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dprotaso @nader-ziada @knative-prow-robot @houshengbo