Skip to content

fix a tracing protocol comment #16015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

fix a tracing protocol comment #16015

merged 1 commit into from
Aug 14, 2025

Conversation

dprotaso
Copy link
Member

We incorrectly stated we can export traces using prometheus (lol)

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2025
@dprotaso
Copy link
Member Author

/assign @Cali0707
/cherry-pick release-1.19

@knative-prow knative-prow bot requested review from dsimansk, gauron99 and skonto August 14, 2025 18:16
@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/assign @Cali0707
/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Cali0707
Cali0707 approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 421c16c into knative:main Aug 14, 2025
63 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #16016

In response to this:

/assign @Cali0707
/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 14, 2025
Merged
@dprotaso dprotaso deleted the fix-config-map-comment branch August 14, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@gauron99 gauron99 Awaiting requested review from gauron99

@skonto skonto Awaiting requested review from skonto

1 more reviewer

@Cali0707 Cali0707 Cali0707 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsimansk dsimansk

@Fedosin Fedosin

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dprotaso @knative-prow-robot @Cali0707 @dsimansk @Fedosin