Skip to content

Conversation

maschmid
Copy link
Contributor

  • set min-scale in TestSystemInternalTLS to not lose the queue-proxy logs

Sporadically, downstream we see TestSystemInternalTLS failing with

    system_internal_tls_test.go:110: TLS not used on requests to queue-proxy: pods "system-internal-tls-mjhqutwi-00001-deployment-6b84b959d7-mjkcs" not found

so here we set min-scale: 1 , same as it's already done in TestTLSCertificateRotation for the same reason.

@knative-prow knative-prow bot requested review from dprotaso, dsimansk and skonto May 21, 2025 10:27
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (e56dd0e) to head (4cdf680).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15895      +/-   ##
==========================================
+ Coverage   80.87%   80.99%   +0.11%     
==========================================
  Files         210      210              
  Lines       16731    16731              
==========================================
+ Hits        13532    13552      +20     
+ Misses       2845     2830      -15     
+ Partials      354      349       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
Copy link

knative-prow bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
@knative-prow knative-prow bot merged commit 3f7000d into knative:main May 22, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants