Fix labels and annotations propagation to k8s service on update

[dsimansk]

Fixes #15891

Proposed Changes

• Fix labels and annotations propagation to k8s service on update

Release Note

Fix labels and annotations propagation to k8s service on update

/cc @dprotaso @Fedosin

At least a few tests would be useful here. I'll add those based on initial feedback.

[dprotaso]

test failures look legit

[dprotaso]

This behaviour should have been captured in conformance tests as per the spec - https://github.com/knative/specs/blob/main/specs/serving/knative-api-specification-1.0.md#service-1

Want to add a test here - https://github.com/knative/serving/tree/main/test/conformance/api/v1

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (bbf34f6) to head (96f85e6).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/testing/v1/service.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15892      +/-   ##
==========================================
- Coverage   80.93%   80.90%   -0.04%     
==========================================
  Files         210      210              
  Lines       16731    16778      +47     
==========================================
+ Hits        13542    13574      +32     
- Misses       2839     2852      +13     
- Partials      350      352       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dsimansk]

/test istio-latest-no-mesh

[dsimansk]

/test istio-latest-no-mesh-tls

[dsimansk]

test failures look legit

Fixed that to preserve existing labels and annotations on k8s service.

This behaviour should have been captured in conformance tests as per the spec - https://github.com/knative/specs/blob/main/specs/serving/knative-api-specification-1.0.md#service-1

Want to add a test here - https://github.com/knative/serving/tree/main/test/conformance/api/v1

@dprotaso thanks for hints. The spec doesn't explicitly mention Kubernetes Service and labels propagation. Should we amend that to the docs? I'll take a look at adding conformance tests to cover it.

[dprotaso]

@dsimansk it's already in the spec

Updates to [Service] spec, metadata.labels, and metadata.annotations of the Service MUST be copied to the appropriate Configuration or Route,

So we just need to update conformance

[dsimansk]

@dprotaso @Fedosin this should be ready for next round. I've simplified the change check per suggestions, thanks. And added conformance tests for annotations (extended existing) and labels.

[Fedosin]

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

@dprotaso any objection to cherry-pick to 1.18 and 1.17 release branches?

[dprotaso]

@dsimansk nope cherry pick away

[dsimansk]

/cherry-pick release-1.18
/cherry-pick release-1.17

[knative-prow-robot]

@dsimansk: cannot checkout release-v1.17: error checking out "release-v1.17": exit status 1 error: pathspec 'release-v1.17' did not match any file(s) known to git

In response to this:

/cherry-pick release-v1.18
/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@dsimansk: new pull request created: #15907

In response to this:

/cherry-pick release-1.18
/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@dsimansk: cannot checkout release-v1.18: error checking out "release-v1.18": exit status 1 error: pathspec 'release-v1.18' did not match any file(s) known to git

In response to this:

/cherry-pick release-v1.18
/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@dsimansk: new pull request created: #15908

In response to this:

/cherry-pick release-1.18
/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.