Skip to content

Conversation

@tcnghia
Copy link
Contributor

@tcnghia tcnghia commented Jun 13, 2024

Proposed Changes

  • Allow ipv6 address for sslip.io in default-domain Job

Release Note

Allow ipv6 address for sslip.io in default-domain Job

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2024
@knative-prow knative-prow bot requested review from ReToCode and izabelacg June 13, 2024 17:26
@codecov
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (2e5d17e) to head (1f32aff).
Report is 4 commits behind head on main.

Files Patch % Lines
cmd/default-domain/main.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15328      +/-   ##
==========================================
- Coverage   84.75%   84.74%   -0.01%     
==========================================
  Files         218      218              
  Lines       13504    13508       +4     
==========================================
+ Hits        11445    11448       +3     
+ Misses       1692     1690       -2     
- Partials      367      370       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Jun 17, 2024

It runs ok for ip4, run it locally.
/lgtm
/hold for @dprotaso

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@dprotaso
Copy link
Member

/lgtm
/approve
/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2024
@knative-prow
Copy link

knative-prow bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
@knative-prow knative-prow bot merged commit e56319d into knative:main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants