Skip to content

Add distinct logging for timeout types #11141

Add distinct logging for timeout types

Add distinct logging for timeout types #11141

Status Failure
Total duration 4m 7s
Artifacts

knative-verify.yaml

on: pull_request
verify  /  Verify Deps and Codegen
3m 59s
verify / Verify Deps and Codegen
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
verify / Verify Deps and Codegen
Process completed with exit code 1.
verify / Verify Deps and Codegen: vendor/knative.dev/pkg/network/error_handler.go#L0
Please run ./hack/update-codegen.sh. diff --git a/vendor/knative.dev/pkg/network/error_handler.go b/vendor/knative.dev/pkg/network/error_handler.go index 6d8ba5b..d0b6bee 100644 --- a/vendor/knative.dev/pkg/network/error_handler.go +++ b/vendor/knative.dev/pkg/network/error_handler.go @@ -17,8 +17,6 @@ limitations under the License. package network import ( - "context" - "errors" "net/http" "os" @@ -29,13 +27,8 @@ import ( // httputil's reverse proxy. // // Deprecated: Use handler.Error instead. - func ErrorHandler(logger *zap.SugaredLogger) func(http.ResponseWriter, *http.Request, error) { return func(w http.ResponseWriter, req *http.Request, err error) { - if errors.Is(err, context.Canceled) { - logger.Debugw("request context canceled", zap.Error(err)) - return - } ss := readSockStat(logger) logger.Errorw("error reverse proxying request; sockstat: "+ss, zap.Error(err)) http.Error(w, err.Error(), http.StatusBadGateway)
verify / Verify Deps and Codegen
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum