Skip to content

Conversation

@tcnghia
Copy link
Contributor

@tcnghia tcnghia commented Mar 15, 2022

Changes

  • 🎁 Add configmap informer factory

#2210 introduced a new manually crafted namespacedkube implementation for secrets. This PR adds a similar factory for configmap.

Release Note
This change has no user-visible impact.

Docs
This change has no user-visible impact.

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 15, 2022
@tcnghia tcnghia force-pushed the add-config-map-informer branch from 013730f to e5ec596 Compare March 15, 2022 23:20
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #2466 (e5ec596) into main (13bdd74) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2466      +/-   ##
==========================================
- Coverage   63.55%   63.53%   -0.02%     
==========================================
  Files         228      228              
  Lines       10007    10007              
==========================================
- Hits         6360     6358       -2     
- Misses       3344     3345       +1     
- Partials      303      304       +1     
Impacted Files Coverage Δ
test/gcs/mock/mock.go 90.32% <0.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bdd74...e5ec596. Read the comment docs.

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants