Skip to content

Cleanup: Remove container flag (var I) #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Aug 15, 2025

Variant I

  • This version simply removes the container flag
  • Much simpler solution compared to Variant II
  • We lose the host builder "defaultability" - you now have to specify --builder=host for all languages to use it.

Changes

  • 🧹 Remove the --container flag for func run
  • The containerization is determined via builder now in func run

/kind cleanup
Fixes #2973

Release notes

Remove the --container flag - builds are determined via builder itself for func run command

Docs


Copy link

knative-prow bot commented Aug 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 15, 2025
Copy link

knative-prow bot commented Aug 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2025
@gauron99 gauron99 changed the title Cleanup: Remove container flag - variant I Cleanup: Remove container flag (var I) Aug 15, 2025
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.60%. Comparing base (e4bd40b) to head (3a5dbf3).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/run.go 87.50% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
+ Coverage   58.95%   59.60%   +0.64%     
==========================================
  Files         132      132              
  Lines       16944    16919      -25     
==========================================
+ Hits         9990    10085      +95     
+ Misses       6025     5877     -148     
- Partials      929      957      +28     
Flag Coverage Δ
e2e-tests 41.04% <81.25%> (+1.40%) ⬆️
integration-tests 54.34% <87.50%> (+1.53%) ⬆️
unit-tests 46.53% <87.50%> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 marked this pull request as ready for review August 18, 2025 12:17
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
@knative-prow knative-prow bot requested review from jrangelramos and nainaz August 18, 2025 12:17
@gauron99 gauron99 requested review from matejvasek and lkingland and removed request for jrangelramos and nainaz August 18, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Reduce complexity of container and builder flag
1 participant