Skip to content

pin knative.dev/pkg so that it compiles #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025

Conversation

dprotaso
Copy link
Member

tektoncd uses an old metrics package we dropped. thus we need to
wait for them to migrate away before resuming these bumps

For now we pin knative.dev/pkg

tektoncd uses an old metrics package we dropped. thus we need to
wait for them to migrate away before resuming these bumps
@knative-prow knative-prow bot requested review from dsimansk and nainaz August 14, 2025 14:05
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 14, 2025
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.72%. Comparing base (46266c9) to head (0b74451).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
+ Coverage   57.96%   59.72%   +1.75%     
==========================================
  Files         132      132              
  Lines       16944    16944              
==========================================
+ Hits         9821    10119     +298     
+ Misses       6222     5868     -354     
- Partials      901      957      +56     
Flag Coverage Δ
e2e-tests 40.99% <ø> (+7.62%) ⬆️
integration-tests 54.46% <ø> (+1.69%) ⬆️
unit-tests 46.66% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Contributor

gauron99 commented Aug 14, 2025

We can bump the tekton we use I think

@dprotaso
Copy link
Member Author

tekton hasn't made the necessary changes yet

@dprotaso
Copy link
Member Author

This is a workaround to unblock knative dep updates

@gauron99
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
Copy link

knative-prow bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e4bd40b into knative:main Aug 14, 2025
42 of 43 checks passed
@dprotaso dprotaso deleted the pin-knative-pkg branch August 14, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants