Skip to content

mcp: adds remote template support #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

KapilSareen
Copy link
Contributor

Changes

  • Adds support for remote func templates in the func mcp

Related Epic #2806

@knative-prow knative-prow bot requested review from dsimansk and vyasgun July 24, 2025 13:39
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2025
Copy link

knative-prow bot commented Jul 24, 2025

Hi @KapilSareen. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.71%. Comparing base (d04ff0a) to head (f8f36c9).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/mcp/help.go 0.00% 77 Missing ⚠️
pkg/mcp/mcp.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2951      +/-   ##
==========================================
+ Coverage   57.55%   59.71%   +2.15%     
==========================================
  Files         132      132              
  Lines       16836    16924      +88     
==========================================
+ Hits         9690    10106     +416     
+ Misses       6237     5860     -377     
- Partials      909      958      +49     
Flag Coverage Δ
e2e-tests 41.04% <0.00%> (+1.16%) ⬆️
integration-tests 54.47% <0.00%> (?)
unit-tests 46.64% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2025
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2025
Copy link

knative-prow bot commented Aug 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KapilSareen, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2025
@gauron99
Copy link
Contributor

gauron99 commented Aug 5, 2025

/retest

@knative-prow knative-prow bot merged commit 2e49dd0 into knative:main Aug 5, 2025
39 checks passed
@KapilSareen KapilSareen deleted the mcp-11-templates branch August 19, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants