Skip to content

Conversation

@dprotaso
Copy link
Contributor

@knative-prow knative-prow bot requested review from KauzClay and skonto December 18, 2023 15:10
@knative-prow
Copy link

knative-prow bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2023
@dprotaso dprotaso mentioned this pull request Dec 18, 2023
14 tasks
@codecov
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c275834) 72.47% compared to head (f7a00f9) 72.76%.

❗ Current head f7a00f9 differs from pull request most recent head 463e116. Consider uploading reports for the commit 463e116 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11     #597      +/-   ##
================================================
+ Coverage         72.47%   72.76%   +0.29%     
================================================
  Files                 9        9              
  Lines               683      683              
================================================
+ Hits                495      497       +2     
+ Misses              159      157       -2     
  Partials             29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Dec 18, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@knative-prow knative-prow bot merged commit 82db271 into knative-extensions:release-1.11 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants