Bug: `kn quickstart kind --registry -k 1.34.0` fails to deploy Serving in kind cluster.

[twoGiants]

Bug Summary

This is a similar bug to #603. The difference here is that it does not get to the Kourier installation but fails after the installation of Serving finished. The command is kn quickstart kind --registry -k 1.34.0. It breaks when patching the config map in install.go#L138. There are two errors happening, check below. I was not able to figure out why. Just executing the patch command from the terminal with kubectl works fine.

System Info

• OS: Fedora Linux 42 (Workstation Edition)
• kubectl: client 1.34.0, server 1.34.0
• kind: 0.30.0
• go: 1.25.0
• docker engine: 28.4.0
• kn quickstart version: 1.19.2

Error

kn quickstart kind --registry -k 1.34.0
Running Knative Quickstart using Kind
✅ Checking dependencies...
    Kind version is: 0.30.0
💽 Installing local registry...
Pulling from library/registry: 2
Digest: sha256:a3d8aaa63ed8681a604f1dea0aa03f100d5895b6a58ace528858a7b332415373: %!s(<nil>)
Status: Image is up to date for registry:2: %!s(<nil>)
☸ Creating Kind cluster...
Creating cluster "knative" ...
 ✓ Ensuring node image (kindest/node:v1.34.0) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹️
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
 ✓ Waiting ≤ 2m0s for control-plane = Ready ⏳
 • Ready after 18s 💚
Set kubectl context to "kind-knative"
You can now use your cluster with:

kubectl cluster-info --context kind-knative

Thanks for using kind! 😊

🔗 Patching node: knative-control-plane
🍿 Installing Knative Serving v1.19.3 ...
    CRDs installed...
    Core installed...
Error from server (InternalError): Internal error occurred: failed calling webhook "config.webhook.serving.knative.dev": failed to call webhook: Post "https://webhook.knative-serving.svc:443/config-validation?timeout=10s": dial tcp 10.96.189.173:443: connect: connection refused

Error: failed to install serving to kind cluster knative: tag resolving configuration: exit status 1
Usage:
  kn-quickstart kind [flags]

Flags:
      --extraMountContainerPath string   set the extraMount containerPath on Kind quickstart cluster
      --extraMountHostPath string        set the extraMount hostPath on Kind quickstart cluster
  -h, --help                             help for kind
      --install-eventing                 install Eventing on quickstart cluster
      --install-serving                  install Serving on quickstart cluster
  -k, --kubernetes-version string        kubernetes version to use (1.x.y) or (kindest/node:v1.x.y)
  -n, --name string                      kind cluster name to be used by kn-quickstart (default "knative")
      --registry                         install registry for Kind quickstart cluster

failed to install serving to kind cluster knative: tag resolving configuration: exit status 1
Error: exit status 1

Additional Info

$ docker ps -a
CONTAINER ID   IMAGE                  COMMAND                  CREATED         STATUS                  PORTS                                              NAMES
301d965cecd9   registry:2             "/entrypoint.sh /etc…"   8 minutes ago   Up 8 minutes            0.0.0.0:5001->5000/tcp                             kind-registry
37daebc2089c   kindest/node:v1.34.0   "/usr/local/bin/entr…"   9 minutes ago   Up 9 minutes            127.0.0.1:44829->6443/tcp, 0.0.0.0:80->31080/tcp   knative-control-plane

/kind bug

[psschwei]

This one I could reproduce:

🍿 Installing Knative Serving v1.19.3 ...
    CRDs installed...
    Core installed...
Error from server (InternalError): Internal error occurred: failed calling webhook "config.webhook.serving.knative.dev": failed to call webhook: Post "https://webhook.knative-serving.svc:443/config-validation?timeout=10s": dial tcp 10.96.192.209:443: connect: connection refused

Error: failed to install serving to kind cluster knative: tag resolving configuration: exit status 1

I think the ?timeout=10s is the issue here, when I was watching the pods, the webhook pod got ready in 11s, but that's 1s too long...

[psschwei]

Putting a small pause before the registry code seemed to get around the issue

	fmt.Println("    Core installed...")

	time.Sleep(5 * time.Second)

	if registries != "" {

so I think that confirms what the problem is.

/triage accepted

[psschwei]

As to a solution, can probably just add a "wait until the webhook is ready" before trying to applying the registry changes

/good-first-issue

[knative-prow]

@psschwei:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

As to a solution, can probably just add a "wait until the webhook is ready" before trying to applying the registry changes

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[twoGiants]

This one I could reproduce:
...
I think the ?timeout=10s is the issue here, when I was watching the pods, the webhook pod got ready in 11s, but that's 1s too long...

Ah now I see it! I was reading 10m because the waitForPods uses 10m. Yeah, that's to short. I can also fix that one.

/assign