Skip to content

Conversation

@kelson42
Copy link
Collaborator

@kelson42 kelson42 commented Oct 8, 2025

Once openzim/libzim#1008 merged

Fixes #1227

@kelson42 kelson42 added this to the 14.1.0 milestone Oct 8, 2025
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMBNTCI¹


¹ Looks good to me but not to CI

@kelson42 kelson42 force-pushed the requires-libzim-9.4.0 branch from 6f4d90a to 92954bb Compare October 24, 2025 10:46
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.05%. Comparing base (7a9edcc) to head (92954bb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1231   +/-   ##
=======================================
  Coverage   43.05%   43.05%           
=======================================
  Files          60       60           
  Lines        4734     4734           
  Branches     2492     2492           
=======================================
  Hits         2038     2038           
  Misses       1075     1075           
  Partials     1621     1621           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelson42 kelson42 merged commit dd09e3c into main Oct 24, 2025
18 checks passed
@kelson42 kelson42 deleted the requires-libzim-9.4.0 branch October 24, 2025 11:16
@veloman-yunkan
Copy link
Collaborator

This will cause the kiwix-build CI/CD fail unless main_project_versions in kiwixbuild/versions.py is updated too.

@kelson42
Copy link
Collaborator Author

@veloman-yunkan I guess you yalk about the CD? We need to release libzim first?

@veloman-yunkan
Copy link
Collaborator

@kelson42 It turned out that the problem I observed with my local build was because my libzim repo was out of date (it was sitting on a branch and was not updated by kiwix-build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade libzim version required

3 participants