Pagination default index is '0' #747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/kiwix-serve.rst
Outdated
| ``start`` (optional, default: 0): this parameter enables pagination of | ||
| results. The response will include up to ``pageLength`` results starting | ||
| with entry # ``start`` from the full list of search results (the first | ||
| result is assumed to have index 1). |
There was a problem hiding this comment.
the first result is no longer assumed to have index 1
There was a problem hiding this comment.
sorry... it's fixed.
There was a problem hiding this comment.
This should be merged as one commit and only after kiwix/libkiwix#1200 is merged.
kelson42
force-pushed
the
doc-fix-search-pagination-offset
branch
from
30040ee to
b109ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation according to kiwix/libkiwix#1200 (search pagination default offset)