MBL-2722: Support edit order deeplinks and push notifications #2638
Conversation
| return self[key].flatMap { Int($0) } | ||
| } | ||
|
|
||
| public func orderEditParam() -> Int? { |
There was a problem hiding this comment.
We don't currently use this param - we use the path, same as the survey URL - but figured I'd implement it so that the :order_edit_id was clear and functional.
amy-at-kickstarter
force-pushed
the
feat/adyer/mbl-2722/implement-link
branch
from
a8221e8 to
22af97f
Compare
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
| EOF | ||
|
|
||
| echo $APNS_DATA | ||
| xcrun simctl push booted com.kickstarter.kickstarter.debug - <<< $APNS_DATA No newline at end of file |
There was a problem hiding this comment.
This handy script will send a test notification to the debug app, which links to a survey URL (or other pledge manager URL).
amy-at-kickstarter
requested review from
a team and
ifosli
and removed request for
a team
There was a problem hiding this comment.
Code changes look good and I love the addition of the send push script. But can we fix it to attempt to match what we actually get from the server? It'd be nice to fix in this pr, but I'm also okay with merging this for now and updating it after team b adds push support for the order edit.
| "aps": { | ||
| "alert": "This is a pledge manager push notification.", | ||
| }, | ||
| "pledgeRedemption": { |
There was a problem hiding this comment.
Based on Yun's explorations and the info from Aidan in this thread https://kickstarter.slack.com/archives/C06EKGN4MHU/p1759175026019329 it looks like we're expecting the wrong pledge manager format (which explains why I've never seen a pledge manager notification; I meant to test this but went on leave before I was able to, and I think it just never got tested). So we probably want to change what this payload looks like, to match the actual payload.
3 participants
📲 What
Support edit order links - as both deeplinks, and as push notifications.
🤔 Why
We want to alert users (via e-mail and push) when they have a pending order edit. This change will route them to the
PledgeManagerWebViewController(see: #2637) for both cases.