-
Notifications
You must be signed in to change notification settings - Fork 999
MBL-2833 Parse pledge redemption messages in MessageService for push notifs #2428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
MBL-2833 Parse pledge redemption messages in MessageService for push notifs #2428
Conversation
| return channels | ||
| } | ||
|
|
||
| @TargetApi(Build.VERSION_CODES.O) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snuck this change in that I missed when I bumped our sdk to Build.VERSION_CODES.O_MR1
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2428 +/- ##
=========================================
Coverage 64.64% 64.64%
Complexity 2391 2391
=========================================
Files 376 376
Lines 28453 28453
Branches 4121 4121
=========================================
Hits 18394 18394
Misses 7800 7800
Partials 2259 2259 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| .survey(gson.fromJson(data["survey"], Survey::class.java)) | ||
| .pledgeRedemption( | ||
| gson.fromJson( | ||
| data["order"], PushNotificationEnvelope.PledgeRedemption::class.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ycheng-kickstarter any chance we can add as reference the ruby controller counterpart? I really wanna double check the data structure we should receive, I've been out of the loop for PM pushes for quite a long time so catching up :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with @ycheng-kickstarter there will be QA session alongside @a-lavis (team-b) in Prod.
📲 What
In MessageService.kt, add logic to parse messages related to Pledge Redemption.
🤔 Why
We forgot to actually add logic to parse pledge redemption messages in MessageService when we first worked on PM push notifs in #2172 ...so users haven't been able to receive PM push notifs
🛠 How
Spent some time with @a-lavis and we determined the backend sends us a payload like this, so we'd need to parse the
orderjson block:👀 See
📋 QA
Story 📖
https://kickstarter.atlassian.net/browse/MBL-2833