-
Notifications
You must be signed in to change notification settings - Fork 998
MBL-2619: upgrade to media3 exoplayer #2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…tin/migrate-to-media3-exoplayer
…tin/migrate-to-media3-exoplayer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good news here, seems there is no longer an option on the creator side of things to add other media to Project Story apart from images/gifs (or via URL) mp3 or mp4 formats are not allowed (attached screenshot of what I see trying to add that type of media file to the project). Meaning basically that we can potentially get rid of AudioElementViewHolder
and VideoElementViewHolder

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forget about my previous comment! still need to support old projects despite apparently the new story editor does not support uploading mp3-mp4 media, here an project example -> https://www.kickstarter.com/projects/airlok/airlok-high-security-bike-storage-hanger-store-loc
…starter/android-oss into imartin/migrate-to-media3-exoplayer
fullscreenButton?.setImageResource(R.drawable.ic_fullscreen_close) | ||
} | ||
|
||
private fun getMediaSource(videoUrl: String): MediaSource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Substituted for MediaItem.Builder()
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2389 +/- ##
============================================
- Coverage 66.38% 66.38% -0.01%
+ Complexity 2349 2348 -1
============================================
Files 378 378
Lines 27904 27904
Branches 4230 4230
============================================
- Hits 18524 18523 -1
Misses 7118 7118
- Partials 2262 2263 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
val fileType = Util.inferContentType(videoUri) | ||
|
||
return if (fileType == C.TYPE_HLS) { | ||
HlsMediaSource.Factory(dataSourceFactory).createMediaSource(MediaItem.fromUri(videoUri)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hence using media3-exoplayer-hls
no need to make any special configurations (will question though at some point if we use hls formats (project story video element high-quality))
📲 What
exoplayer:2.17.1
tomedia3-exoplayer:1.7.1
(latest)🤔 Why
🛠 How
📥 the interface for
Player.Listener
is marked with @unsableapi , but heads up is correct to use it, It's not deprecated or broken—it works now, but will likely have changes on following versions👀 See
ProjectsWeLove.mp4
| | |
📋 QA
Story 📖
MBL-2619