TestRenderHelmChart* once again call validateYAML, though it changes #12570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bad rebase/merge in kgateway-dev#12498 removed some testing. The testing is now better because it finds more helm chart lint. Hence some charts have changed. The error message is more helpful, too. version.Version is mocked so that tests pass locally, not just on CI, and REFRESH_GOLDEN=true works locally too. Signed-off-by: David L. Chandler <[email protected]>
github-actions
bot
added
kind/cleanup
puertomontt
approved these changes
Oct 9, 2025
davidjumani
approved these changes
Oct 9, 2025
lgadban
reviewed
Oct 9, 2025
lgadban
requested changes
Oct 9, 2025
Failures look like:
--- FAIL: TestRenderHelmChart (0.10s)
--- FAIL: TestRenderHelmChart/agentgateway_OmitDefaultSecurityContext_true_GWP_via_GWC (0.01s)
deployer_helm.go:144:
Error Trace: /Users/davidchandler/k_deployer-test-validateyaml-again/test/deployer/deployer_helm.go:144
/Users/davidchandler/k_deployer-test-validateyaml-again/test/deployer/internal_helm_test.go:74
Error: Should be empty, but was bytes.Join({
"---\n# Source: kgateway-proxy/templates/gateway/agent-gateway-dep",
"loyment.yaml\napiVersion: v1\nkind: ServiceAccount",
- " DLC",
"\nmetadata:\n name: gw\n labels:\n kgateway: kube-gateway\n h",
"elm.sh/chart: kgateway-proxy-1.0.0-ci1\n app.kubernetes.io/nam",
... // 4944 identical bytes
}, "")
Test: TestRenderHelmChart/agentgateway_OmitDefaultSecurityContext_true_GWP_via_GWC
Messages: bytes.Join({
"---\n# Source: kgateway-proxy/templates/gateway/agent-gateway-dep",
"loyment.yaml\napiVersion: v1\nkind: ServiceAccount",
- " DLC",
"\nmetadata:\n name: gw\n labels:\n kgateway: kube-gateway\n h",
"elm.sh/chart: kgateway-proxy-1.0.0-ci1\n app.kubernetes.io/nam",
... // 4944 identical bytes
}, "")
%!(EXTRA string=the golden file, which can be refreshed via `REFRESH_GOLDEN=true go test ./test/deployer', is test/deployer/testdata/agentgateway-omitdefaultsecuritycontext-out.yaml)
Signed-off-by: David L. Chandler <[email protected]>
timflannagan
approved these changes
Oct 10, 2025
lgadban
approved these changes
Oct 10, 2025
Signed-off-by: David L. Chandler <[email protected]>
lgadban
approved these changes
Oct 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
chandler-solo
added a commit
to chandler-solo/kgateway
that referenced
this pull request
Oct 14, 2025
…gateway-dev#12570) Signed-off-by: David L. Chandler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bad rebase/merge in #12498 removed some testing.
The testing is now better because it finds more helm chart lint. Hence some charts have changed. The error message is more helpful, too.
version.Version is mocked so that tests pass locally, not just on CI, and REFRESH_GOLDEN=true works locally too.
Change Type
/kind cleanup
Changelog
Additional Notes