Skip to content

Conversation

@josh-pritchard
Copy link
Contributor

Description

Refactors the gateway parameters customization from a complex ExtraGatewayParameters map-based system to a simple 1:1 HelmValuesGeneratorOverride pattern.

Change Type

/kind cleanup

Changelog

NONE

Additional Notes

Copilot AI review requested due to automatic review settings October 6, 2025 21:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the gateway parameters customization system from a complex map-based approach using ExtraGatewayParameters to a simpler 1:1 HelmValuesGeneratorOverride pattern.

  • Replaces ExtraGatewayParameters with direct HelmValuesGeneratorOverride functions
  • Removes complex group-kind mapping logic and the ExtraGatewayParameters struct
  • Simplifies the override mechanism to use a single function instead of multiple parameters

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/deployer/deployer_helm.go Updates test function signature to use HelmValuesGeneratorOverride instead of ExtraGatewayParameters
pkg/setup/setup.go Changes Options struct field from ExtraGatewayParameters to HelmValuesGeneratorOverride
pkg/deployer/gateway_parameters.go Removes ExtraGatewayParameters struct definition
internal/kgateway/setup/setup.go Updates function signatures and field names throughout setup
internal/kgateway/deployer/gateway_parameters_test.go Updates test cases to use new override pattern
internal/kgateway/deployer/gateway_parameters.go Major refactor removing map-based logic and complex fallback mechanisms
internal/kgateway/controller/start.go Updates controller configuration to use new override pattern
internal/kgateway/controller/controller.go Changes function signatures and field names for controller builders
examples/plugin/main.go Removes unused extraGatewayParametersFactory function and import
Comments suppressed due to low confidence (1)

pkg/deployer/gateway_parameters.go:1

  • Removed import is still being used in other parts of the file via the Inputs struct's Client field. The removal appears incorrect.
package deployer

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

inputs: inputs,
knownGWParameters: []client.Object{&v1alpha1.GatewayParameters{}}, // always include default GatewayParameters
extraHVGenerators: make(map[schema.GroupKind]deployer.HelmValuesGenerator),
}
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed extraHVGenerators map initialization suggests this field was removed from the struct, but the knownGWParameters field logic may need to be updated to handle the simplified override pattern consistently.

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none labels Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant